Bad requests are being swallowed

[ericsaupe]

https://github.com/boomerdigital/solidus_avatax_certified/blob/master/app/models/spree/avalara_transaction.rb#L63

If the response is bad there is no way of knowing that anything went wrong. I think returning the 0 taxes is a good move for the user but makes debugging and fixing issues difficult for the developer.

[dhonig]

@ericsaupe yes....This one bothers me. Yet I think its hard to think of a good fallback strategy that suits everyone. Do you have any reccomendations for what the service should do? Maybe just write the error to the logs? In production you might wish to calculating a sensible default, consult a tax table for certain states or in fact return 0 and eat the tax rather than lose the sale. Interested to hear what your team is doing and then perhaps we can get @acreilly to introduce some improvements here.

[ericsaupe]

Something like this would be fine, I'm open to changing the logging text. I just need some way of seeing that something happened in a log file or anywhere I can check and monitor for issues and resolve them quickly.

if response.error?
  logger.error "Failed tax calculation #{response.result}"
  return { 'totalTax' => 0.0 }
end

[dhonig]

@ericsaupe at one point we used to generate an avatax log. @acreilly can tell you what happened to this. Feel free to send a PR or @acreilly will tackle this on her next cycle of maintenance. Thanks for reporting!

[ericsaupe]

The avatax log is still there, the code above would use that afaik

[dhonig]

K: couldn't remember if we removed that log. thanks.

[acreilly]

Is this not functioning properly for logging errors?
https://github.com/boomerdigital/solidus_avatax_certified/blob/master/app/models/tax_svc.rb#L48-L59