Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lazy loaded images aren't pulled in #12

Open
mitechie opened this issue Oct 17, 2012 · 7 comments
Open

lazy loaded images aren't pulled in #12

mitechie opened this issue Oct 17, 2012 · 7 comments

Comments

@mitechie
Copy link
Member

See http://www.wired.com/wiredenterprise/2012/10/ff-inside-google-data-center/all/

The images are loaded as required. You can check for the lazy-data for the real url and pull that into play as the adjusted src attribute.

@trebsirk
Copy link

trebsirk commented Sep 6, 2013

my scraped docs have the images in the html, but they're not showing. There's a blank box for the image, and when I click in the box, it takes me to the original page, but shows nothing on my breaded docs. I'm using Chrome to inspect the element and this is the src tag:

<img class="aligncenter size-full wp-image-224531" title="luxinside-hermesENVOL" src="http://www.wired.com/images/1x1.trans.gif" data-lazy-src="http://www.wired.com/design/wp-content/uploads/2013/09/luxinside-hermesENVOL1.jpg" alt="" width="660" height="402">

and it shows this:

It's just displaying an empty 600x402 box. Any idea on what I'm doing wrong?

@mitechie
Copy link
Member Author

mitechie commented Sep 6, 2013

@trebsirk I'm going to guess that wired.com is blocking links to the images on their site from another url. You should be able to check this by going to the chrome network tab when you open up the breadability generated page and see what the network tab says the response was for that image call out.

@mitechie
Copy link
Member Author

mitechie commented Sep 6, 2013

@trebsirk reading you thing again, make sure to check out the latest version as some code was updated to help better grab images along with the content in the result. That's version 0.1.13

@trebsirk
Copy link

trebsirk commented Sep 6, 2013

It doesn't show that particular image being sent over the network. bummer. i just installed 0.1.13 today. same issue/bug/feature.
screen shot 2013-09-06 at 12 08 54 pm

@mitechie
Copy link
Member Author

mitechie commented Sep 6, 2013

@trebsirk what is the url you originally tried to make readable?

@mitechie
Copy link
Member Author

mitechie commented Sep 6, 2013

@trebsirk ah ok, so right. That is this bug. The real url of the image is in the attribute data-lazy-src and breadability needs to update the image tag to set the normal src= to whatever data-lazy-src equals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants