Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the latest version of my homework #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

update the latest version of my homework #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
226 changes: 226 additions & 0 deletions others/jmun/csshomework.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,226 @@

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should delete this line

body {
background: #13818a;
color: #626668;
}



Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line 6-8, why skip 3 lines?

ul.solarsystem li{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make your coding style consistent throughout: either li { or li{ ; name: or name :
make sure to check every line

text-indent:-9999px;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again, either text-indent: or text-indent :

border: 2px solid white;
position: absolute;
}

span{
position: absolute;
width: 10px;
height: 10px;
border-radius: 5px;
}

li.pluto{
width: 580px;
height: 580px;
border-radius: 292px;
top: 30px;
left: 190px;
}

li.pluto span {
background: #7c6a5c;
top: 79px;
left: 79px;
}

li.neptune{
width: 520px;
height: 520px;
border-radius: 262px;
top: 60px;
left: 220px;
}

li.neptune span {
background: #77c2ec;
top: 0px;
left: 200px;
}

li.uranus{
width: 460px;
height: 460px;
border-radius: 232px;
top: 90px;
left: 250px;
}

li.uranus span {
background: #82b3d1;
top: 7px;
left: 300px;
}

li.saturn{
width: 400px;
height: 400px;
border-radius: 202px;
top: 120px;
left: 280px;
}

li.saturn span {
background: #dfd3a9;
top: 24px;
left: 300px;
}

li.saturn span.ring {
width: 12px;
height: 12px;
border: 2px solid #5a4e34;
left: -3px;
top: -3px;
}

li.jupiter{
width: 340px;
height: 340px;
border-radius: 172px;
top: 150px;
left: 310px;
}

li.jupiter span {
background: #e0ae6f;
top: 67px;
left: 24px;
}

li.asteroids_meteorids {
background: url(http://neography.com/experiment/circles/solarsystem/asteroids_meteorids.png) no-repeat 0 0;
top: 150px;
left: 310px;
z-index: 1;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does this mean? don't copy something you're not sure of.

width: 340px;
height: 340px;
border-radius: 172px;
border: none;
}

li.mars{
width: 280px;
height: 280px;
border-radius: 142px;
top: 180px;
left: 340px;
}

li.mars span {
background: #aa4200;
top: 0px;
left: 175px;
}

li.earth{
width: 220px;
height: 220px;
border-radius: 112px;
top: 210px;
left: 370px;
}

li.earth span {
background: #06c;
top: 56px;
left: 5px;
}

li.earth span.moon {
width: 4px;
height: 4px;
border-radius: 2px;
background: #ccc;
top: 12px;
left: 12px;
}

li.venus{
width: 160px;
height: 160px;
border-radius: 82px;
top: 240px;
left: 400px;
}

li.venus span {
background: #bf8639;
top: 118px;
left: 5px;
}

li.mercury{
width: 100px;
height: 100px;
border-radius: 52px;
top: 270px;
left: 430px;
}

li.mercury span {
background: #b6bac5;
top: 10px;
left: 10px;
}

li.sun {
width: 40px;
height: 40px;
border-radius: 20px;
background: #fc3;
top: 302px;
left: 462px;
border: none;
z-index: 100;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again

}
li.sun span {
width: 60px;
height: 60px;
border-radius: 30px;
}
/*animation*/
ul.solarsystem li {
-webkit-animation-iteration-count:infinite;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't copy; you should google webkit to learn about what it is.

-webkit-animation-timing-function:linear;
-webkit-animation-name:orbit;

-moz-animation-iteration-count:infinite;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is kind of redundant

-moz-animation-timing-function:linear;
-moz-animation-name:orbit;
}
li.earth span {
-webkit-animation-iteration-count:infinite;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't copy

-webkit-animation-timing-function:linear;
-webkit-animation-name:moon;

-moz-animation-iteration-count:infinite;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

redundant

-moz-animation-timing-function:linear;
-moz-animation-name:moon;
}
li.mercury {-webkit-animation-duration:5s; -moz-animation-duration:5s;}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again, redundant

li.venus {-webkit-animation-duration:8s; -moz-animation-duration:8s;}
li.earth {-webkit-animation-duration:12s; -moz-animation-duration:12s;}
li.earth span {-webkit-animation-duration:2s; -moz-animation-duration:2s;}
li.mars {-webkit-animation-duration:20s; -moz-animation-duration:20s;}
li.asteroids_meteorids {-webkit-animation-duration:50s; -moz-animation-duration:50s;}
li.jupiter {-webkit-animation-duration:30s; -moz-animation-duration:30s;}
li.saturn {-webkit-animation-duration:60s; -moz-animation-duration:60s;}
li.uranus {-webkit-animation-duration:70s; -moz-animation-duration:70s;}
li.neptune {-webkit-animation-duration:100s; -moz-animation-duration:100s;}
li.pluto {-webkit-animation-duration:120s; -moz-animation-duration:120s;}

@-webkit-keyframes orbit { from { -webkit-transform:rotate(0deg) } to { -webkit-transform:rotate(360deg) } }
@-webkit-keyframes moon { from { -webkit-transform:rotate(0deg) } to { -webkit-transform:rotate(360deg) } }

@-moz-keyframes orbit { from { -moz-transform:rotate(0deg) } to { -moz-transform:rotate(360deg) } }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

@-moz-keyframes moon { from { -moz-transform:rotate(0deg) } to { -moz-transform:rotate(360deg) } }
22 changes: 22 additions & 0 deletions others/jmun/csshomework.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
<!DOCTYPE html>
<html>
<head>
<link rel="stylesheet" type="text/css" href="csshomework.css">
</head>
<body>
<ul class="solarsystem">
<li class="sun"><span>Sun</span></li>
<li class="pluto"><span>Pluto</span></li>
<li class="neptune"><span>Neptune</span></li>
<li class="uranus"><span>Uranus</span></li>
<li class="saturn"><span>Saturn<span class="ring">Ring</span></span></li>
<li class="jupiter"><span>Jupiter</span></li>
<li class="asteroids_meteorids"><span>Asteroids_Meteorids</span></li>
<li class="mars"><span>Mars</span></li>
<li class="earth"><span>Earth<span class="moon">Moon</span></span></li>
<li class="venus"><span>Venus</span></li>
<li class="mercury"><span>Mercury</span></li>
</ul>
</body>

</html>