Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Micro task] Update a Bokeh example plot #7

Open
pavithraes opened this issue Mar 2, 2023 · 17 comments
Open

[Micro task] Update a Bokeh example plot #7

pavithraes opened this issue Mar 2, 2023 · 17 comments
Labels
outreachy-may-2023 Internship projects for Outreachy's May 2023 round

Comments

@pavithraes
Copy link
Member

pavithraes commented Mar 2, 2023

Select a Bokeh plot from the examples gallery, review it for accessibility (primarily, check the colors used in the plot), and update it to use more accessible colours if needed.

Share the plot you are working on a comment on this issue, so that we don't have multiple participants working on the same example.

You can make a PR against bokeh/bokeh#11481 for this micro task to update plots. If you find plots that don't need updating, share it on this issue as a comment.

@pavithraes pavithraes added the outreachy-may-2023 Internship projects for Outreachy's May 2023 round label Mar 2, 2023
@BhaswatiRoy
Copy link

Hello @pavithraes
I have changed the colors of Band Plot to more accessible colors with a good color contrast ratio
bokeh/bokeh#12922

@chinmaychahar
Copy link

Hi @pavithraes
Updated examples/styling/mathtext/latex_schrodinger.py to a more accessible color palette referencing the docs.

#bokeh/bokeh/pull/12923

@Soot3
Copy link

Soot3 commented Mar 8, 2023

Changed colorbar_log example from viridis to iridescent

#bokeh/bokeh/pull/12929

@robinokwanma
Copy link

robinokwanma commented Mar 10, 2023

Updated Color pallete for examples\plotting\histogram.py to be more visible and less conflicting

bokeh/bokeh#12937

@AnishereMariam
Copy link

AnishereMariam commented Mar 15, 2023

Updated colour palette data/linear_cmap.py.

@KesharwaniArpita
Copy link

hey , @pavithraes , @bryevdv i have changed the color of the jitter graph taken from the gallery. Can you review my work at https://github.com/KesharwaniArpita/outreach-programs/tree/Gallery_bokeh
?

@bryevdv
Copy link
Member

bryevdv commented Mar 19, 2023

Hi @KesharwaniArpita Thanks for the links. I am not sure that the new colors are an improvement according to the criteria of accessibility. One of the most common color deficiences is an inability to distinguish red from green, but these examples seem to be updated us use both those hues together. I think the jitter example may also have issues with low background/foreground contrast.

Here are some links that may be helpful:

@Faith-Nchifor
Copy link

Faith-Nchifor commented Mar 21, 2023

  1. Link: https://docs.bokeh.org/en/latest/docs/examples/basic/bars/basic.html
  2. https://docs.bokeh.org/en/latest/docs/examples/basic/areas/stacked_area.html
    Hello @pavithraes. I don't think these plots need updating. I think the bar plot is assessible enough even though it uses a default color. The palette (tol) used by the stacked area plot is assessible.

@Faith-Nchifor
Copy link

Hello mentors @bryevdv , @pavithraes. I have a question. I noticed that some colors in the example plots were generated using loops. For instance colors = np.array([(r, g, 150) for r, g in zip(50+2*x, 30+2*y)], dtype="uint8"). Does this exercise also involve replacing these colors with the color palettes even if the colors are already looking good?

@bryevdv
Copy link
Member

bryevdv commented Mar 23, 2023

Hi @Faith-Nchifor those are some very old examples that have also been used widely in various public project materials over the years. I think perhaps they could be improved, but I think it's not so clear cut and needs a more involved discussion. I'd advise looking at some of the other examples before those.

@Faith-Nchifor
Copy link

okay @bryevdv.

@Faith-Nchifor
Copy link

I worked on the slope plot bokeh/bokeh#12959

@Soot3
Copy link

Soot3 commented Mar 23, 2023

Saw some of those when I was trying out the examples. They all still work on the current version, while palettes like tol will output errors on older versions like bokeh-2.4.3 (which is the default in a Google Colab notebook)

Hi @Faith-Nchifor those are some very old examples that have also been used widely in various public project materials over the years. I think perhaps they could be improved, but I think it's not so clear cut and needs a more involved discussion. I'd advise looking at some of the other examples before those.

@fractaldatalearning
Copy link

Hello! I created a PR to make a small change to the span example in the gallery, changing from solid to dashed lines. TBH this is my first time making a PR to something other than a project between me and friends, so I’m very open to any feedback about the process as well as code.

@fractaldatalearning
Copy link

@bryevdv
Copy link
Member

bryevdv commented Apr 2, 2023

Thanks @fractaldatalearning jus FYI very many of the example plots have been updated in the repo but to not yet appear in the published gallery, because there has not yet been a new release since those changes. At this point, in order to see the true current state of the gallery, you would need to build the docs locally as described in the contributor guide.

@fractaldatalearning
Copy link

fractaldatalearning commented Apr 2, 2023

Thanks @fractaldatalearning jus FYI very many of the example plots have been updated in the repo but to not yet appear in the published gallery, because there has not yet been a new release since those changes. At this point, in order to see the true current state of the gallery, you would need to build the docs locally as described in the contributor guide.

Thanks for the clarification! It makes sense that there would actually be many more plots that are updated by now. To find any additional visualizations to work on, I’ll look through the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
outreachy-may-2023 Internship projects for Outreachy's May 2023 round
Projects
None yet
Development

No branches or pull requests

10 participants