Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outreachy First Contribution By Faith Nchifor ( Explore NYC taxi trips dataset) #18

Open
Faith-Nchifor opened this issue Mar 13, 2023 · 4 comments

Comments

@Faith-Nchifor
Copy link

Faith-Nchifor commented Mar 13, 2023

As @bryevdv instructed.
Hello @bryevdv, @pavithraes,
Here is the link to my gist: https://gist.github.com/Faith-Nchifor/2eaf2132e1f4cc6a67cd81ba5212e2c3
Also, this notebook runs live on Kaggle where all the plots are visible: https://www.kaggle.com/code/faithnchifor/nyc-yellow-taxi-trips-viz
My project of interest is Create a blog post series: "Fundamentals of Data Visualization in Bokeh"
Your all good and bad feedback are welcome.
Thanks

@pavithraes
Copy link
Member

@Faith-Nchifor Thanks for sharing! This satisfies the microtask, and we'll share more detailed feedback soon. :)

@Faith-Nchifor
Copy link
Author

Thank you @pavithraes

@pavithraes
Copy link
Member

@Faith-Nchifor Your notebook looks great! I especially like the payments types plot and your effort to map the "payment method" numbers to the values. :)

I think you can consider:

  • adding more narrative text to explain the process and reasons behind certain operations, and
  • updating some of the plots' y-axes that currently have exponents with TickFormatters

Since #22 has the same file, you can close it to keep discussions on this issue. Let us know if you'd like another review anytime. I think your task looks complete, and can be submitted on the Outreachy portal whenever you're happy with it. 🌻

@Faith-Nchifor
Copy link
Author

Faith-Nchifor commented Mar 23, 2023

Hello @pavithraes. Thank you for these corrections and especially for the tip on TickFormatters . I was able to successfully update the axes of my plots and I would love for you to go through my notebook again and give a review (preferably the Kaggle file: https://www.kaggle.com/code/faithnchifor/nyc-yellow-taxi-trips-viz)
Also, I made sure to add some narrative texts to the notebook.
I wish to know if there is anything else I can do to make the analysis more meaningful.
Thank you so much for your time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants