Added WithTransportCredentials option to be able to manually set TransportCredentials #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manual transport creds
Updating go.mod with my github URL
Revert "Updating go.mod with my github URL"
ashktn
approved these changes
Jun 10, 2024
|
@bojand - Sorry to pester, but any chance we could get this reviewed and possible merged in if everything is in order? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're currently trying to benchmark proxyless Istio using xDS and I needed to make an update to be able to manually set the TransportCredentials in order to follow this guide: https://istio.io/latest/blog/2021/proxyless-grpc/
This is basically building on top of the work that was already done here in PR #300