Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to pass response to end user #322

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

cuichenli
Copy link

We have a use case to check what is in the response. However, ghz does not support this functionality atm (correct me if I am wrong). Hope we can add this. Thanks!

@bojand
Copy link
Owner

bojand commented Nov 14, 2021

Hello, thanks for the PR!

I think I get the idea, but can you elaborate some more on the context and usage and how this solves some of the issues you're having.

Also I think perhaps the response and stop channels should be different options.

Finally it would be helpful to add tests for these options and usage.

@cuichenli
Copy link
Author

Sorry for the late reply. So the context is we are doing some performance testing while also considering the accuracy of our services. So we would like to verify if the received response matches certain criteria (like how many data were responded). By adding this option, we can store the responses to some place and check the result at some point of time. I know we can use the --debug option to store the response as well, but then we will have to take care of the other unrelated logs as well, which is not ideal.

I think this can also address the #247 .

For the other two points, I will work on them later.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants