Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TooManyTestSteps applies to test-templates but shouldn't #51

Open
joelwhitehouse opened this issue Apr 22, 2018 · 0 comments
Open

TooManyTestSteps applies to test-templates but shouldn't #51

joelwhitehouse opened this issue Apr 22, 2018 · 0 comments

Comments

@joelwhitehouse
Copy link

Request

I'd like to request a new linter rule. Currently the rule TooManyTestSteps applies to regular Test Cases as well as test-template test cases; I'd like to restrict TooManyTestSteps to apply only to regular Test Cases and a new, separate rule TooManyTemplateDataRows to apply to only to test-templates.

Reasoning

A new rule would be more consistent with the Robot Framework documentation. When a regular test case is too long, it has "too many steps", but test-templates are different. According to the User Guide section on test-templates, a test-template body consists of data rows, not "steps", so the TooManyTestSteps rule technically doesn't apply to a templated test case. A separate TooManyTemplateDataRows rule for templated test cases would be more consistent with existing RobotFramework documentation.

Additionally, it may be desirable to restrict templated test cases to a different length than regular test cases. When regular test cases have too many steps, they're dense and unreadable. But the bare, tabular format of the test-template syntax can contain many more data rows and still look clean. A separate rule would give developers the option to keep Test Cases short and sweet while allowing templates to breathe a little bit.

Defaults

Since TooManyTestSteps defaults to 10, a TooManyTemplateDataRows rule could sensibly default to 15.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant