Method always returns false - Refactor Bug

[yurelle]

gradle-tomcat-plugin/plugin/src/main/groovy/com/bmuschko/gradle/tomcat/tasks/TomcatRun.groovy

Line 116 in c103bf4

webXml.exists()

This function always returns false. Several years ago, this code was refactored to add the if condition (in this commit; line: [old]-97 [new]-111). In the original code, the webXml.exists() was the last line of the function, and thus acted as a return value. However, once moved to inside an if-block, this auto return no longer works. Thus, this function always returns false. A manual return needs to be added to this line.

Fix:
return webXml.exists()

[bmuschko]

Looks like you are right. Would you be interested in providing a pull request?

[yurelle]

Thank you, but I don't have access to the code base right now. You can take the credit. :-)

…

-Yurelle

On Sat, Apr 14, 2018 at 1:35 PM, Benjamin Muschko ***@***.***> wrote: Looks like you are right. Would you be interested in providing a pull request? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#174 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AWoRsdqtIlrbsVG3N61Fhh6sW1KyPIpsks5tojN7gaJpZM4SK9-1> .

[bmuschko]

@yurelle Just as a heads up: I am asking because I won't have the time to look into it soon. If you have an urgent need for the bug to be fixed then you'll need to provide a pull request.