Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to calculate intersection points for circles #49

Open
dhowe opened this issue Sep 12, 2021 · 5 comments
Open

Option to calculate intersection points for circles #49

dhowe opened this issue Sep 12, 2021 · 5 comments

Comments

@dhowe
Copy link

dhowe commented Sep 12, 2021

may have missed this, but would be nice to be able to get circle/circle and circle/line intersection points as well (either 1 or 2)

@bmoren
Copy link
Owner

bmoren commented Sep 12, 2021

agreed.

This will take some amount of non-related sub-collision to achieve. eg. collision detection that is not inherent to the calculation of the collision being calculated. Circle collisions are not based on where the intersection happened, instead based on distance from the center point.

But I agree it would be nice to have, but was never implemented because it is an additional step.

@brownsloth
Copy link

@bmoren I would be willing to take this up.

@bmoren
Copy link
Owner

bmoren commented Oct 4, 2021

Hi @brownsloth sounds good, make a PR when it's ready and I'll review.

THANK YOU!

@brownsloth
Copy link

@bmoren I am done with the changes. This might sound trivial but I need to test them, what's the procedure for that?

@bmoren
Copy link
Owner

bmoren commented Oct 4, 2021

There is no formal procedure, but if you can provide some context / sketches for your testing procedure that should be good enough for me.

I'd just try and make a variety of sketches that think about the normal and edge cases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants