Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import terms from GSSO & HP #1

Open
ckindermann opened this issue Oct 3, 2024 · 1 comment · May be fixed by #2
Open

Import terms from GSSO & HP #1

ckindermann opened this issue Oct 3, 2024 · 1 comment · May be fixed by #2

Comments

@ckindermann
Copy link
Collaborator

ckindermann commented Oct 3, 2024

The original mapping of variables in the Global Code Book to ontology terms included the following terms from GSSO and HP:

nih_race GSSO:002199
nih_disability GSSO:001811
nih_disability GSSO:001810
nih_alcohol_yn GSSO:006602
nih_lifetime_use_alcohol GSSO:006602
nih_alcohol_yrs GSSO:006602
nih_alcohol_frequency GSSO:006602
nih_premature_birth GSSO:009644

nih_deaf HP:0000364

I omitted GSSO and HP in the initial setup of the GCBO repository because importing respective modules of the above terms leads our QC pipeline to throw errors. There are a lot of issues with GSSO as reported by the OBO Dashboard -- over 1000 errors according to the ROBOT report.

For all the variables above, we have links to ontology terms from other ontologies, e.g., SYMP, NBO, or NCIT. The only two exceptions are:

nih_premature_birth GSSO:009644
nih_race GSSO:002199

However, in both cases, there are corresponding terms in NCIT that GSSO links to:

nih_premature_birth http://purl.obolibrary.org/obo/NCIT_C92861
nih_race http://purl.obolibrary.org/obo/NCIT_C17049

Can't we use these terms? Why do we need GSSO?

@ckindermann
Copy link
Collaborator Author

Many terms in GSSO appear to be copied from other ontologies (such as NCIT) and contain textual definitions that are copied verbatim from Wikipedia - without being marked as direct quotes as far as I can tell. I understand that GSSO is still in development. However, I am hesitant to build on GSSO at this point.

@ckindermann ckindermann linked a pull request Oct 3, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant