Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for custom animation #27

Open
iTonyYo opened this issue Dec 10, 2019 · 3 comments
Open

support for custom animation #27

iTonyYo opened this issue Dec 10, 2019 · 3 comments

Comments

@iTonyYo
Copy link

iTonyYo commented Dec 10, 2019

If you can support custom animation, it will be more flexible.

Message.tsx#L93

@baleeds
Copy link

baleeds commented Apr 10, 2020

How would you feel about the library using react-transition-group, which would allow us to customize the animations using CSS. The react-spring seems like overkill for this use case, and it isn't very performant for me.

@baleeds
Copy link

baleeds commented Apr 10, 2020

Plus it's an extra dep, which just doesn't seem necessary.

@bmcmahen
Copy link
Owner

Happy to accept a PR for react-transition-group support, and agree that CSS animations would be preferable for an independent library. I built this for use within a project which included react-spring, so I wasn't worried about the extra dep.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants