-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dnt
(Do Not Track) option for Vimeo
#5
Comments
@blynx Hi Steffen, This would be a nice feature to have. |
Hi! I created this PR: #6, but I just edited it quickly here in github. Could you have a look and see if it works for you? I try to get my hands back on an processwire instance to check that out soon I hope. (I think this should just make the option available in the module settings - maybe there are more new options to adapt actually ...!?) Also, looking at https://stackoverflow.com/questions/63173525/vimeo-embed-do-not-track and following the concers to https://stackoverflow.com/questions/44837450/recommended-method-to-prevent-any-content-inside-iframe-from-setting-cookies there could be implemented some fancier control. |
Oh and btw, does anyone of you want to help maintain this module (and maybe another one ... !?) Since I'm not having my hands on processwire right now and probably wont have any time soon. |
@blynx Hi Steffen, thanks for waking up for this :) Will try out your changes later this afternoon. Do you have a roadmap or other changes in mind for this module? |
Not really, I just thought there might be other new properties like dnt which could be added. So I/we could have just a look at the vimeo/youtube docs again and see whats new and could be added here. |
@blynx - I found that it didn't work for me with the default |
ah mh, seemed ok from the vimeo docs. I just changed it. |
Hi @blynx - would you please add a
dnt
option for Vimeo?More info: https://www.thomasvantuycom.com/privacy-friendly-video-embeds/
Thanks.
The text was updated successfully, but these errors were encountered: