Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delay field to Platform entity #5

Open
calebsheridan opened this issue Mar 2, 2020 · 0 comments
Open

Add delay field to Platform entity #5

calebsheridan opened this issue Mar 2, 2020 · 0 comments

Comments

@calebsheridan
Copy link
Member

calebsheridan commented Mar 2, 2020

Abstract

Each protocol has a different delay. This information should be available at a Platform level.

Delay variants

In some cases, the delay is hardcoded. In others, it is set at a protocol level. In others, it is set at on a per-parameter basis.

Schema update

type Platform @entity {
  id: ID!
  delay: BigInt! # This is the new field; delay is defined in seconds
  target: [Target]! @derivedFrom(field: "platform")
  timelock: [Timelock]! @derivedFrom(field: "platform")
}

Existing functions affected

For each platform mapping, the createPlatform function must be updated. Where applicable, the data should be taken from events or smartContracts.

New function

A new function such as updatePlatformDelay is required for some platforms. This will update the platform delay and should be triggered based on the relevant event(s).

@calebsheridan calebsheridan changed the title Add delay info to protocols Add delay field to Platform entity Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant