-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove JSON requirement from documentation #1
Comments
That's a good point, thanks! |
Good idea about the badge. May I suggest using https://poser.pugx.org/ for it? |
Love it! Thank you for the suggestion 😄 |
@garak it seems i'm having a bad time using the badges, they won't display on github but they works nicely in my PHPStorm's preview. I'm surely missing something here, do you have any idea on what might be ? |
Just figured out that the github proxy url didn't liked the https redirect of the badge url. |
The README is reporting in the "requirements" section:
This is useless, since the JSON extension is bundled inside php itself since 8.0 and this library requires php 8.1 or above.
By the way, you could even remove the entire "requirements" section, since it's already declared in the composer file (and all the versions below 8.1 are currently out of support)
The text was updated successfully, but these errors were encountered: