Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: support for colour scheme #3

Open
ncarboni opened this issue Apr 30, 2019 · 7 comments
Open

Request: support for colour scheme #3

ncarboni opened this issue Apr 30, 2019 · 7 comments
Labels
enhancement New feature or request

Comments

@ncarboni
Copy link

ncarboni commented Apr 30, 2019

Love the package but not a fan of dark theme. I was wonder if you would consider supporting in the future the Soda colour scheme.

@ncarboni ncarboni changed the title Colour schema Colour scheme Apr 30, 2019
@ncarboni ncarboni changed the title Colour scheme Request: support for colour scheme Apr 30, 2019
@blake-regalia
Copy link
Owner

blake-regalia commented Apr 30, 2019

The package actually ships with a light color scheme as well (although it is still in beta).

Screen Shot 2019-04-30 at 10 48 54 AM

If you are a big fan of the Soda color scheme, maybe you'd be interested in submitting a PR for integrating a similar one into this package? The schemes in the package right now are actually generated using a simple starting palette of 10 colors and then shifting the shades by some amount for each scope; see here.

@blake-regalia blake-regalia added the enhancement New feature or request label Apr 30, 2019
@ncarboni
Copy link
Author

ncarboni commented May 1, 2019

The package actually ships with a light color scheme as well (although it is still in beta).

I tried to select it from the colour scheme menu, but, unfortunately, every time I set the syntax of a file to Turtle it comes back to use "macarom dark" colour scheme.
That being said, the light colour scheme seems nice. I would happily use it if I manage to fix the erratic behaviour

@blake-regalia
Copy link
Owner

blake-regalia commented May 1, 2019

@ncarboni I added a section to the README that documents how to override the default color scheme. I hope this helps!

@ncarboni
Copy link
Author

ncarboni commented May 2, 2019

@ncarboni I added a section to the README that documents how to override the default color scheme. I hope this helps!

Thank you! It definitively helped!

If you are a big fan of the Soda color scheme, maybe you'd be interested in submitting a PR for integrating a similar one into this package? The schemes in the package right now are actually generated using a simple starting palette of 10 colors and then shifting the shades by some amount for each scope; see here.

Thanks for the pointer, I will try to work on it!

@berezovskyi
Copy link

berezovskyi commented Aug 7, 2019

Could you please refrain from forcing a color scheme that users cannot reset (ie one can't set it to null to inherit the scheme used for the rest of the editor)?

@blake-regalia
Copy link
Owner

@berezovskyi The whole point of this package is to provide rich syntax highlighting which requires custom color schemes. You are welcome to override the color scheme in your settings file but you might as well use one of the existing sparql or turtle packages instead if you are not interested in the features of this package anyway.

@berezovskyi
Copy link

I see! Honestly, I only needed NTriples support. And let me apologise for not thanking you enough for your great work, Blake!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants