Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for CSRF token did not return an X-CSRF-Token header #226

Open
MayGo opened this issue Oct 16, 2024 · 2 comments · May be fixed by #228
Open

Request for CSRF token did not return an X-CSRF-Token header #226

MayGo opened this issue Oct 16, 2024 · 2 comments · May be fixed by #228
Labels
bug Something isn't working

Comments

@MayGo
Copy link

MayGo commented Oct 16, 2024

Describe the bug
I am getting error "Request for CSRF token did not return an X-CSRF-Token header "

To Reproduce

Run mantle deploy --environment dev
Loading project:
  ╷
  │  Loaded config file ./mantle.yml
  │  Selected provided environment configuration dev
  │  Loading previous state from remote object eeur/trimateh-mantle-states/dunkeep.mantle-state.yml
  │  
  ╰─ Succeeded

Deploying resources:
  ╷
  │  
  ╰─ Request for CSRF token did not return an X-CSRF-Token header.

Error: Process completed with exit code 1.

Expected behavior
All my tokens should be valid and it should work

Environment (please complete the following information):

  • OS: MacOS
  • Mantle Version 0.11.16

Additional context

I saw that there were some commits regarding auth, eg: b1c53a9
So, I hope my tokens are fine, that there is a general issue, and that a release with a fix will be soon.

Awesome project btw!

@MayGo MayGo added the bug Something isn't working label Oct 16, 2024
@blake-mealey
Copy link
Owner

Thanks for the report! This was initially caused by a recent Roblox incident but it seems the Roblox team may not actually revert the change in behaviour. v0.11.17-prerelease includes a temporary fix for the issue, which may still have intermittent failures.

I'm currently investigating implementing a more correct solution for CSRF token management, but I'm having some difficulties so I may just change the endpoint which rbx_auth currently uses to retrieve the CSRF token.

@MayGo
Copy link
Author

MayGo commented Oct 17, 2024

Thanks for the temporary fix. Successful deploy made my day!
The reference to initial incident is nice, always good to know the cause

@blake-mealey blake-mealey linked a pull request Oct 20, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants