Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(rbx_cookie): put CLI dependencies behind feature flag #193

Merged
merged 2 commits into from
Aug 6, 2023
Merged

chore(rbx_cookie): put CLI dependencies behind feature flag #193

merged 2 commits into from
Aug 6, 2023

Conversation

filiptibell
Copy link
Contributor

@filiptibell filiptibell commented Aug 4, 2023 •
edited
Loading

This PR puts the clap and env_logger dependencies of rbx_cookie behind a new feature flag named cli, which is enabled by default. This will let library consumers of rbx_cookie disable the CLI-specific dependencies as such:

[dependencies]
rbx_cookie = { version = "x.y.z", default-features = false }

Fixes #192

@vercel
Copy link

vercel bot commented Aug 4, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mantle-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 4, 2023 10:46pm

@blake-mealey blake-mealey changed the title Put CLI dependencies behind feature flag in rbx_cookie chore(rbx_cookie): put CLI dependencies behind feature flag Aug 6, 2023
@blake-mealey blake-mealey merged commit 7d2b990 into blake-mealey:main Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rbx_cookie lib contains cli-specific dependencies
2 participants
@filiptibell @blake-mealey