Updating game pass icons does not work

[guidojw]

Describe the bug
When updating a game pass icon, Mantle errors with a 404 Not Found.

To Reproduce
Steps to reproduce the behavior:

1. Deploy a game pass with initial icon.
2. Change the icon file and deploy again.
3. Mantle errors with 404 Not Found.

Expected behavior
The icon is correctly updated.

Environment (please complete the following information):

• OS: Windows
• Mantle Version 0.11.1

Additional context
It looks like this is because of the usage of POST https://publish.roblox.com/v1/game-passes/:gamePassId/icon, which does not seem to exist (tested this with Postman).

mantle/rbx_mantle/src/roblox_api.rs

Line 1536 in 0adfb63

"https://publish.roblox.com/v1/game-passes/{}/icon",

When manually updating the game pass icon and checking the browser logs, only one request is made and this is to https://www.roblox.com/game-pass/update, same as in update_game_pass:

mantle/rbx_mantle/src/roblox_api.rs

Line 1514 in 0adfb63

.post("https://www.roblox.com/game-pass/update")

When the game pass icon is changed, this request is encoded as gzip and includes the new image.

[blake-mealey]

Indeed it looks like they have removed the docs for that endpoint from here: https://publish.roblox.com/docs.

I try to avoid using the www.roblox.com APIs whenever possible because they are more likely to change or become unsupported. I'll see if there's a replacement API for the one they removed but if not I can switch to using the website API.

[blake-mealey]

You're right though. Mantle already uses that endpoint and I'm not seeing anything else, so might as well switch to that.

[blake-mealey]

@guidojw this turned out to be more complex than it looks. Internally Mantle considers game passes and game pass icons to be separate resources. This lets it only update the game pass if the description (for example) changes and only updates the icon if the icon file changes. However, if you upload just an icon with that update endpoint it actually overwrites the name and description properties.

Therefore, I would need to combine the two into a single game pass resource. Unfortunately this means that whenever the developer changes the description, the icon will need to be reuploaded.

Additionally, the update endpoint does not return the new icon asset ID, so we are forced to make a second request to fetch the icon asset ID from the game pass.

Although not ideal, it's better than not working at all. I should have a patch out soon but just updating you on why this is more complex than it seems.

[blake-mealey]

Also realized this would require a new state file version which is rather annoying. Before publishing this change I want to make a ticket on the devforum to see if Roblox will respond to this.

[blake-mealey]

Created this ticket: https://devforum.roblox.com/t/update-game-pass-icon-web-api-no-longer-exists/1834807

[blake-mealey]

Roblox has confirmed that this was intentionally removed but they missed on communicating it, and that they are intending on replacing it with an Open Cloud API.

Since Open Cloud cannot be supported by Mantle yet, I'll go ahead and implement the above change.

[blake-mealey]

This is fixed in the latest release (0.11.2)

[guidojw]

Hi yeah, thanks for the quick response and fix!