Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FF120 breaks legacy customization used by lepton? #825

Closed
2 of 9 tasks
ggreco opened this issue Nov 22, 2023 · 3 comments
Closed
2 of 9 tasks

FF120 breaks legacy customization used by lepton? #825

ggreco opened this issue Nov 22, 2023 · 3 comments
Labels
Browser::Upstream Changes or bugs from Firefox Env::Mac Issues on Mac Issue::Bug Something isn't working Issue::Duplicate This issue or pull request already exists

Comments

@ggreco
Copy link

ggreco commented Nov 22, 2023

Describe the bug

It seems that updating to firefox 120 the leptonChrome.css is not applied anymore...

I've verified that in the update process firefox have not changed any settings on my configuration and chrome/userChrome.css points to chrome/css/lepthonChrome.css.

Expected behavior

Smaller tabs without separation from the section below...

Screenshots

Here is what I get:

image

OS

Mac OS

OS - Others

No response

Firefox Version

120.0

Distribution

Theme

Theme - More Info

(I always use the dark theme of macOS)

user.js setup

user.js setup
/user_pref("toolkit.legacyUserProfileCustomizations.stylesheets", true);

// Proton Enabled #127 || Removed at 97 #328 (Maintained for compatibility with ESR)
user_pref("browser.proton.enabled", true);

// Fill SVG Color
user_pref("svg.context-properties.content.enabled", true);

// CSS Color Mix - 88 Above
user_pref("layout.css.color-mix.enabled", true);

// CSS Blur Filter - 88 Above
user_pref("layout.css.backdrop-filter.enabled", true);

// Restore Compact Mode - 89 Above
user_pref("browser.compactmode.show", true);

// about:home Search Bar - 89 Above
user_pref("browser.newtabpage.activity-stream.improvesearch.handoffToAwesomebar", false);

// CSS's `:has()` selector #457 - 103 Above
user_pref("layout.css.has-selector.enabled", true);

// Browser Theme Based Scheme - Will be activate 95 Above
// user_pref("layout.css.prefers-color-scheme.content-override", 3);

// ** Theme Related Options ****************************************************
// == Theme Distribution Settings ==============================================
// The rows that are located continuously must be changed `true`/`false` explicitly because there is a collision.
// https://github.com/black7375/Firefox-UI-Fix/wiki/Options#important
user_pref("userChrome.tab.connect_to_window",          true); // Original, Photon
user_pref("userChrome.tab.color_like_toolbar",         true); // Original, Photon

user_pref("userChrome.tab.lepton_like_padding",        true); // Original
user_pref("userChrome.tab.photon_like_padding",       false); // Photon

user_pref("userChrome.tab.dynamic_separator",          true); // Original, Proton
user_pref("userChrome.tab.static_separator",          false); // Photon
user_pref("userChrome.tab.static_separator.selected_accent", false); // Just option
user_pref("userChrome.tab.bar_separator",             false); // Just option

user_pref("userChrome.tab.newtab_button_like_tab",     true); // Original
user_pref("userChrome.tab.newtab_button_smaller",     false); // Photon
user_pref("userChrome.tab.newtab_button_proton",      false); // Proton

user_pref("userChrome.icon.panel_full",                true); // Original, Proton
user_pref("userChrome.icon.panel_photon",             false); // Photon

// Original Only
user_pref("userChrome.tab.box_shadow",                 true);
user_pref("userChrome.tab.bottom_rounded_corner",      true);

// Photon Only
user_pref("userChrome.tab.photon_like_contextline",   false);
user_pref("userChrome.rounding.square_tab",           false);
</details>


### Additional context

I've checked the involved files `user.js`, `chroma/userChrome.js`... and none of them has been changed since I installed lepton.... (at least the modified date isn't)
@ggreco ggreco added the Issue::Bug Something isn't working label Nov 22, 2023
@leandrolnh
Copy link

Have you updated to the v8.5.0 release? That contains fixes for FF120.

@ggreco
Copy link
Author

ggreco commented Nov 22, 2023

... no did it now and it works, thanks!

@ggreco ggreco closed this as completed Nov 22, 2023
@black7375
Copy link
Owner

Unfortunately, Mozilla breaks it frequently, and you can read about it in #799

@black7375 black7375 added Issue::Duplicate This issue or pull request already exists Env::Mac Issues on Mac Browser::Upstream Changes or bugs from Firefox labels Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Browser::Upstream Changes or bugs from Firefox Env::Mac Issues on Mac Issue::Bug Something isn't working Issue::Duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

3 participants