-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Control the wordclock software with systemd and use a python virtual environment #250
Open
oxivanisher
wants to merge
15
commits into
bk1285:main
Choose a base branch
from
oxivanisher:feature/systemd_setup
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxivanisher
changed the title
Control the wordclock software with systemd
Control the wordclock software with systemd and use a python virtual environment
Jul 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Why the python 3 virtual environment?
Since a change in python pip (which itself is now part of the newest debian/raspian release 12 "bookworm), pip does no longer allow the user to install libraries for the whole system. Yes, this can be an initial inconvenience, but it is way cleaner and the reason python devs push this change. There is also a theoretical solution to use a python environment with
--user
, but this is broken also. The smart solution is to use a virtual environment anyways but use as many system libs as possible. I tried to compile all the requirements on a RPi Zero but stopped the process after 10 hours ...Also this PR includes the git commands to circumvent problems arising with newer git versions (see #245). The possible removal of the python call for git (
self.currentGitHash
) should be considered, but this is out of scope of this PR.I tested this version on bullseye as much as possible and the setup is working on a freshly installed bookworm.
I would be happy if somebody else is testing this and is verifying if the documentation is done correctly, I never used sphinx before. Also I have my wordclock running on bookworm within a virtual environment for several weeks now without any issue.
This PR resolves #246