-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
beet hackathon demo - If the authorization is removed re-authorization is not done and also no prompt comes up for it. #123
Comments
Please assign to me @sschiessl-bcp |
Can you describe the steps to reproduce? |
OS Linux Ubuntu Issue: installation steps need more details for Linux Resolution below: Step 1) Need to do a prebuild for Linux: https://electronjs.org/docs/development/build-instructions-linux --ensure the below libraries exist
Step 2)For the node_modules/tiny-secp256k1
Step 3) For starting the beet app use
Time taken : 2hrs Now proceed with issue |
#122 is a part of the ticket |
Re-authentication issue Observed: Suggestion: A) Would need to make a re-authentication variable in beet
I prefer suggestion 1) over 2) |
From beet-js side, this may not be handled differently when signing up. Option to handle it from Beet side: When Beet sees an incoming request with a hash given, but can't find the hash in its own database it must display a popup to the user that this happened because it might be a possible security risk. If the user confirms, Beet tries to match the hash with the chains / accounts it has in store, creates the entry in the app database and shows the user the link popup just as normal. Since this is a strategic change, @clockworkgr s opinion and approval is needed. |
Is this still the case with the upgraded client? Or can we now close this issue? |
The text was updated successfully, but these errors were encountered: