Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support naming variations for google-chrome on linux #46

Open
jevonearth opened this issue Aug 28, 2015 · 4 comments
Open

Support naming variations for google-chrome on linux #46

jevonearth opened this issue Aug 28, 2015 · 4 comments

Comments

@jevonearth
Copy link

Different distros package google-chorme with different names.

Ubuntu: google-chrome
Arch: google-chrome-stable

Would be nice if launchpad check for several common variations.

@alan-morey
Copy link

Assuming you have the google-chrome-stable package installed under Ubuntu, then both google-chrome-stable and google-chrome are symlinks under /usr/bin.

Symlinks as follows:

/usr/bin/google-chrome -> /etc/alternatives/google-chrome -> /usr/bin/google-chrome-stable ->  /opt/google/chrome/google-chrome

@mazswojejzony
Copy link
Contributor

Starting with 0.5.0 you can define path to e..g Chrome like this: LAUNCHPAD_CHROME=path/to/chrome. See docs.

@mattyclarkson
Copy link
Contributor

The LAUNCHPAD_CHROME is a work around but requires me to set that up on all my build slaves. Can the project do something similar to karma-chrome-launcher in that it falls backwards through the browser names.

You could change this line to support an array and each is done in turn. Or add a key called executables so that the dictionary looks like:


  chrome: {
    pathQuery: 'which ${executable}',
    executables: ['chromium-browser', 'chromium', 'chrome', 'google-chrome'],
    process: 'chrome',
    opensTab: true,
    args: ['--no-first-run']
  },

And the search runs through each of the executables replacing ${executable} in the pathQuery?

It would be a great usability win if launchpad just fired up on GNU/Linux distros by default like Karma.

@daffl
Copy link
Contributor

daffl commented Apr 28, 2016

This can probably be done fairly easy by changing the pathQuery at https://github.com/ekryski/launchpad/blob/master/lib/local/platform/unix.js#L5 to 'which chromium-browser chromium chrome google-chrome'. Always open for PRs.

mattyclarkson added a commit to mattyclarkson/launchpad that referenced this issue Apr 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants