Finding Edge Fails when Edge DevTools are enabled

[zevisert]

When windows getEdgeDirectory runs, this filter

launchpad/lib/local/platform/windows.js

Lines 90 to 91 in b1d254a

	var edgeFolders = fs.readdirSync(systemApps).filter(function(folder) {
	return folder.indexOf('Microsoft.MicrosoftEdge') === 0;

results in inclusion of both these paths:

• "C:\Windows\SystemApps\Microsoft.MicrosoftEdge_8wekyb3d8bbwe"
• "C:\Windows\SystemApps\Microsoft.MicrosoftEdgeDevToolsClient_8wekyb3d8bbwe"

On my system the DevToolsClient folder comes first, so launchpad returns that path right after.

launchpad/lib/local/platform/windows.js

Line 96 in b1d254a

return edgeFolders[0] || systemApps;

The DevToolsClient folder doesn't contain a copy of MicrosoftEdge.exe so launchpad fails to detect edge on my system.

Easy fix

• Just filter again to remove paths that contain DevToolsClient
• or change the filter line 91 to have a trailing underscore (but this is more of a hack)

[chasenlehara]

Thanks for filing this issue @zevisert!

I see this function being used here:

launchpad/lib/local/platform/windows.js

Line 41 in b1d254a

defaultLocation: path.join(getEdgeDirectory(), 'MicrosoftEdge.exe'),

I wonder if it should check for MicrosoftEdge.exe in each of the folders it gets, and then select the first one if there are multiple?