Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

force to kill instance on windows #108

Open
pYr0x opened this issue Dec 8, 2018 · 0 comments
Open

force to kill instance on windows #108

pYr0x opened this issue Dec 8, 2018 · 0 comments
Labels
bug help wanted

Comments

@pYr0x
Copy link

pYr0x commented Dec 8, 2018 •
edited
Loading

i would recommend to force the killing process and use the PID
https://github.com/bitovi/launchpad/blob/master/lib/local/instance.js#L90
should be: command = 'taskkill /f /pid ' + this.id;

on my windows machine the taskkill was not working an node will not exit because a chrome will still exists
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pYr0x @chasenlehara