Skip to content

Commit

Permalink
Merge branch 'player-testing/integration-test-app-setup' into player-…
Browse files Browse the repository at this point in the history
…testing/cavy-setup
  • Loading branch information
rolandkakonyi committed Nov 28, 2023
2 parents 4a8c76c + 3263ada commit d91ea99
Show file tree
Hide file tree
Showing 6 changed files with 19 additions and 9 deletions.
4 changes: 3 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
# Changelog

## [Unreleased]
## [0.14.2] (2023-11-27)

### Fixed

- Android: `onEvent` callback not being called on `PlayerView`
- iOS: `onEvent` on iOS has incomplete payload information
- tvOS: Picture in Picture sample screen has unwanted padding
- iOS: hide home indicator when entering fullscreen mode in the example application

## [0.14.1] (2023-11-16)

Expand Down
4 changes: 2 additions & 2 deletions example/ios/Podfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -483,7 +483,7 @@ PODS:
- React-jsi (= 0.72.6-1)
- React-logger (= 0.72.6-1)
- React-perflogger (= 0.72.6-1)
- RNBitmovinPlayer (0.14.1):
- RNBitmovinPlayer (0.14.2):
- BitmovinPlayer (= 3.49.0)
- GoogleAds-IMA-iOS-SDK (= 3.18.4)
- GoogleAds-IMA-tvOS-SDK (= 4.8.2)
Expand Down Expand Up @@ -744,7 +744,7 @@ SPEC CHECKSUMS:
React-runtimescheduler: acd6b708338a975a9bb4c594eac0f018f5c15fa3
React-utils: c1cf85c0cd58c11dfb95104a78c608e95d03eb9e
ReactCommon: 1dabb8f37c44d8c7370238bd8f504cbad0cfd941
RNBitmovinPlayer: 29822e8853cfc97c179ab24cda7902ecf6f3f1e0
RNBitmovinPlayer: 020d9bcad225ddee065212cbba660673e456f391
RNCPicker: 529d564911e93598cc399b56cc0769ce3675f8c8
RNScreens: 4a1af06327774490d97342c00aee0c2bafb497b7
SocketRocket: f32cd54efbe0f095c4d7594881e52619cfe80b17
Expand Down
1 change: 1 addition & 0 deletions example/src/screens/BasicFullscreenHandling.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ export default function BasicFullscreenHandling({
setFullscreenMode(isFullscreen);
navigation.setOptions({
headerShown: !isFullscreen, // show/hide top bar
autoHideHomeIndicator: isFullscreen, // show/hide home indicator on iOS
});
})
).current;
Expand Down
12 changes: 8 additions & 4 deletions example/src/screens/BasicPictureInPicture.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import React, { useCallback, useEffect, useState } from 'react';
import { Button, Platform, StyleSheet } from 'react-native';
import { Button, Platform, StyleSheet, View, ViewProps } from 'react-native';
import { useFocusEffect } from '@react-navigation/native';
import {
Event,
Expand Down Expand Up @@ -116,9 +116,9 @@ export default function BasicPictureInPicture({
[]
);

const ContainerView = Platform.isTV ? View : SafeAreaContainer;
return (
<SafeAreaView
edges={Platform.isTV ? [] : ['bottom', 'left', 'right']}
<ContainerView
style={
// On Android, we need to remove the padding from the container when in PiP mode.
Platform.OS === 'android' && isInPictureInPicture
Expand All @@ -137,10 +137,14 @@ export default function BasicPictureInPicture({
onPictureInPictureExit={onPictureInPictureExitEvent}
onPictureInPictureExited={onEvent}
/>
</SafeAreaView>
</ContainerView>
);
}

function SafeAreaContainer(props: ViewProps): JSX.Element {
return <SafeAreaView edges={['bottom', 'left', 'right']} {...props} />;
}

const styles = StyleSheet.create({
container: {
flex: 1,
Expand Down
5 changes: 4 additions & 1 deletion example/src/screens/LandscapeFullscreenHandling.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,10 @@ export default function LandscapeFullscreenHandling({
new SampleFullscreenHandler(fullscreenMode, (isFullscreen: boolean) => {
console.log('on fullscreen change');
setFullscreenMode(isFullscreen);
navigation.setOptions({ headerShown: !isFullscreen });
navigation.setOptions({
headerShown: !isFullscreen, // show/hide top bar
autoHideHomeIndicator: isFullscreen, // show/hide home indicator on iOS
});
})
).current;
useFocusEffect(
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "bitmovin-player-react-native",
"version": "0.14.1",
"version": "0.14.2",
"description": "Official React Native bindings for Bitmovin's mobile Player SDKs.",
"main": "lib/index.js",
"module": "lib/index.mjs",
Expand Down

0 comments on commit d91ea99

Please sign in to comment.