From 45ffaef932be20048e3b4b7731a09693b73dbab2 Mon Sep 17 00:00:00 2001 From: bitbalint <99177189+bitbalint@users.noreply.github.com> Date: Tue, 19 Dec 2023 10:20:43 +0100 Subject: [PATCH 1/8] Create CODEOWNERS Require the player-android team to review Android-specific changes and the player-ios team to review iOS-specific changes. --- .github/CODEOWNERS | 4 ++++ 1 file changed, 4 insertions(+) create mode 100644 .github/CODEOWNERS diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS new file mode 100644 index 00000000..2c07b784 --- /dev/null +++ b/.github/CODEOWNERS @@ -0,0 +1,4 @@ +ios/ @player-ios +example/ios/ @player-ios +android/ @player-android +example/android/ @player-android From 99c104f3266367d7eafdf3cf0712e7c918ae06a1 Mon Sep 17 00:00:00 2001 From: bitbalint <99177189+bitbalint@users.noreply.github.com> Date: Tue, 19 Dec 2023 11:03:29 +0100 Subject: [PATCH 2/8] Update CODEOWNERS --- .github/CODEOWNERS | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 2c07b784..8dad8ce0 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1,4 +1,4 @@ -ios/ @player-ios -example/ios/ @player-ios -android/ @player-android -example/android/ @player-android +ios/ @bitmovin/player-ios +example/ios/ @bitmovin/player-ios +android/ @bitmovin/player-android +example/android/ @bitmovin/player-android From e1496fa365bb946350d1c1f73f2af1127a99a948 Mon Sep 17 00:00:00 2001 From: Roland Kakonyi Date: Wed, 31 Jan 2024 13:44:36 +0100 Subject: [PATCH 3/8] ci: use M1 mac GitHub Actions runners on CI --- .github/workflows/ci-ios-tvos.yml | 6 +++--- .github/workflows/create-sdk-update-pr.yml | 2 +- .github/workflows/start-release-train.yml | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/ci-ios-tvos.yml b/.github/workflows/ci-ios-tvos.yml index 18162763..cfdda3bd 100644 --- a/.github/workflows/ci-ios-tvos.yml +++ b/.github/workflows/ci-ios-tvos.yml @@ -38,7 +38,7 @@ env: jobs: code-style-ios: name: Code style iOS - runs-on: macOS-latest + runs-on: macOS-14 steps: - name: Checkout uses: actions/checkout@v4 @@ -55,7 +55,7 @@ jobs: test-build-ios: name: Build iOS - runs-on: macOS-12 + runs-on: macOS-14 steps: - name: Checkout uses: actions/checkout@v4 @@ -125,7 +125,7 @@ jobs: test-build-tvos: name: Build tvOS - runs-on: macOS-12 + runs-on: macOS-14 steps: - name: Checkout uses: actions/checkout@v4 diff --git a/.github/workflows/create-sdk-update-pr.yml b/.github/workflows/create-sdk-update-pr.yml index 9a206e37..790bf582 100644 --- a/.github/workflows/create-sdk-update-pr.yml +++ b/.github/workflows/create-sdk-update-pr.yml @@ -21,7 +21,7 @@ env: jobs: update: name: Update SDK version - runs-on: macos-latest + runs-on: macos-14 env: GH_TOKEN: ${{ secrets.GH_TOKEN }} steps: diff --git a/.github/workflows/start-release-train.yml b/.github/workflows/start-release-train.yml index 2fa66b88..fa28764c 100644 --- a/.github/workflows/start-release-train.yml +++ b/.github/workflows/start-release-train.yml @@ -21,7 +21,7 @@ concurrency: jobs: create_release_pr: name: Create release branch and bump version - runs-on: macos-latest + runs-on: macos-14 outputs: branch_name: ${{ steps.branching.outputs.branch_name }} steps: From d1b8bd973855dc1eca22c63c9f3185f9ff964100 Mon Sep 17 00:00:00 2001 From: Roland Kakonyi Date: Wed, 31 Jan 2024 13:46:26 +0100 Subject: [PATCH 4/8] ci: bump to Xcode 14.3 on CI --- .github/workflows/ci-ios-tvos.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci-ios-tvos.yml b/.github/workflows/ci-ios-tvos.yml index cfdda3bd..c39e89db 100644 --- a/.github/workflows/ci-ios-tvos.yml +++ b/.github/workflows/ci-ios-tvos.yml @@ -45,7 +45,7 @@ jobs: - uses: maxim-lobanov/setup-xcode@v1 with: - xcode-version: '14.2' + xcode-version: '14.3' - name: Install dependencies run: brew bundle install @@ -69,7 +69,7 @@ jobs: - uses: maxim-lobanov/setup-xcode@v1 with: - xcode-version: '14.2' + xcode-version: '14.3' - name: Install node_modules run: yarn install --frozen-lockfile @@ -139,7 +139,7 @@ jobs: - uses: maxim-lobanov/setup-xcode@v1 with: - xcode-version: '14.2' + xcode-version: '14.3' - name: Install node_modules run: yarn install --frozen-lockfile From 57b1ef7caa563dd914029191292655731728bd2d Mon Sep 17 00:00:00 2001 From: Update Bot Date: Fri, 16 Feb 2024 11:44:10 +0000 Subject: [PATCH 5/8] chore(ios): update ios player version to 3.56.1 --- RNBitmovinPlayer.podspec | 2 +- example/ios/Podfile.lock | 14 +++++++------- integration_test/ios/Podfile.lock | 16 ++++++++-------- 3 files changed, 16 insertions(+), 16 deletions(-) diff --git a/RNBitmovinPlayer.podspec b/RNBitmovinPlayer.podspec index 35f2f0ef..910c4931 100644 --- a/RNBitmovinPlayer.podspec +++ b/RNBitmovinPlayer.podspec @@ -19,7 +19,7 @@ Pod::Spec.new do |s| s.source_files = "ios/**/*.{h,m,mm,swift}" s.dependency "React-Core" - s.dependency "BitmovinPlayer", "3.55.0" + s.dependency "BitmovinPlayer", "3.56.1" s.ios.dependency "GoogleAds-IMA-iOS-SDK", "3.18.4" s.tvos.dependency "GoogleAds-IMA-tvOS-SDK", "4.8.2" end diff --git a/example/ios/Podfile.lock b/example/ios/Podfile.lock index b399940b..48c9e326 100644 --- a/example/ios/Podfile.lock +++ b/example/ios/Podfile.lock @@ -3,10 +3,10 @@ PODS: - BitmovinAnalyticsCollector/Core - BitmovinPlayerCore (~> 3.48) - BitmovinAnalyticsCollector/Core (3.5.0) - - BitmovinPlayer (3.55.0): + - BitmovinPlayer (3.56.1): - BitmovinAnalyticsCollector/BitmovinPlayer (~> 3.0) - - BitmovinPlayerCore (= 3.55.0) - - BitmovinPlayerCore (3.55.0) + - BitmovinPlayerCore (= 3.56.1) + - BitmovinPlayerCore (3.56.1) - boost (1.76.0) - DoubleConversion (1.1.6) - FBLazyVector (0.72.6-1) @@ -424,7 +424,7 @@ PODS: - React-logger (= 0.72.6-1) - React-perflogger (= 0.72.6-1) - RNBitmovinPlayer (0.17.0): - - BitmovinPlayer (= 3.55.0) + - BitmovinPlayer (= 3.56.1) - GoogleAds-IMA-iOS-SDK (= 3.18.4) - GoogleAds-IMA-tvOS-SDK (= 4.8.2) - React-Core @@ -592,8 +592,8 @@ EXTERNAL SOURCES: SPEC CHECKSUMS: BitmovinAnalyticsCollector: 8b9a4b07f1fa2a43996ba29598eab6f50a25edfe - BitmovinPlayer: 4c42de316c9f56552fcde5cf20701329f55cc0db - BitmovinPlayerCore: 6699939e9c37b6047c3afc224245f01c60089ead + BitmovinPlayer: 567750b902de8d7234fa80c9c41349adca47e845 + BitmovinPlayerCore: 62abf17a7df2a35fc20fd8f29ad388c1388f32b8 boost: 43f331345fd5d44b60bf621e7e579ae7b8fda687 DoubleConversion: 234abba95e31cc2aada0cf3b97cdb11bc5b90575 FBLazyVector: 58c22987e2cd1eebb2e3bc9f7756d87b14c32d3c @@ -639,7 +639,7 @@ SPEC CHECKSUMS: React-runtimescheduler: acd6b708338a975a9bb4c594eac0f018f5c15fa3 React-utils: c1cf85c0cd58c11dfb95104a78c608e95d03eb9e ReactCommon: 1dabb8f37c44d8c7370238bd8f504cbad0cfd941 - RNBitmovinPlayer: 0c7a8e2ad2bf2d9b52b1c4fac0121c30b75a38e4 + RNBitmovinPlayer: fe0befae771204c4f9f60fb43745812922a21024 RNCPicker: 529d564911e93598cc399b56cc0769ce3675f8c8 RNScreens: 4a1af06327774490d97342c00aee0c2bafb497b7 SocketRocket: f32cd54efbe0f095c4d7594881e52619cfe80b17 diff --git a/integration_test/ios/Podfile.lock b/integration_test/ios/Podfile.lock index 8378ce51..26a284d6 100644 --- a/integration_test/ios/Podfile.lock +++ b/integration_test/ios/Podfile.lock @@ -3,10 +3,10 @@ PODS: - BitmovinAnalyticsCollector/Core - BitmovinPlayerCore (~> 3.48) - BitmovinAnalyticsCollector/Core (3.5.0) - - BitmovinPlayer (3.55.0): + - BitmovinPlayer (3.56.1): - BitmovinAnalyticsCollector/BitmovinPlayer (~> 3.0) - - BitmovinPlayerCore (= 3.55.0) - - BitmovinPlayerCore (3.55.0) + - BitmovinPlayerCore (= 3.56.1) + - BitmovinPlayerCore (3.56.1) - boost (1.76.0) - DoubleConversion (1.1.6) - FBLazyVector (0.72.6-1) @@ -412,8 +412,8 @@ PODS: - React-jsi (= 0.72.6-1) - React-logger (= 0.72.6-1) - React-perflogger (= 0.72.6-1) - - RNBitmovinPlayer (0.16.0): - - BitmovinPlayer (= 3.55.0) + - RNBitmovinPlayer (0.17.0): + - BitmovinPlayer (= 3.56.1) - GoogleAds-IMA-iOS-SDK (= 3.18.4) - GoogleAds-IMA-tvOS-SDK (= 4.8.2) - React-Core @@ -560,8 +560,8 @@ EXTERNAL SOURCES: SPEC CHECKSUMS: BitmovinAnalyticsCollector: 8b9a4b07f1fa2a43996ba29598eab6f50a25edfe - BitmovinPlayer: 4c42de316c9f56552fcde5cf20701329f55cc0db - BitmovinPlayerCore: 6699939e9c37b6047c3afc224245f01c60089ead + BitmovinPlayer: 567750b902de8d7234fa80c9c41349adca47e845 + BitmovinPlayerCore: 62abf17a7df2a35fc20fd8f29ad388c1388f32b8 boost: 43f331345fd5d44b60bf621e7e579ae7b8fda687 DoubleConversion: 234abba95e31cc2aada0cf3b97cdb11bc5b90575 FBLazyVector: 58c22987e2cd1eebb2e3bc9f7756d87b14c32d3c @@ -602,7 +602,7 @@ SPEC CHECKSUMS: React-runtimescheduler: acd6b708338a975a9bb4c594eac0f018f5c15fa3 React-utils: c1cf85c0cd58c11dfb95104a78c608e95d03eb9e ReactCommon: 1dabb8f37c44d8c7370238bd8f504cbad0cfd941 - RNBitmovinPlayer: 765aa1ba9d469e5be9c65fdd9f8f41a68ee40c53 + RNBitmovinPlayer: fe0befae771204c4f9f60fb43745812922a21024 SocketRocket: f32cd54efbe0f095c4d7594881e52619cfe80b17 Yoga: f67f5769ce78049c5fe798bc735f04535c7bc1ac From b3c82b7b4745c161d2f60f4b770dfb9758eba9a3 Mon Sep 17 00:00:00 2001 From: Roland Kakonyi Date: Fri, 16 Feb 2024 15:12:13 +0100 Subject: [PATCH 6/8] chore: improve example app documentation --- README.md | 1 + example/README.md | 44 ++++++++++++++++++++++++++++++++++---------- 2 files changed, 35 insertions(+), 10 deletions(-) diff --git a/README.md b/README.md index d81df941..49a67549 100644 --- a/README.md +++ b/README.md @@ -48,6 +48,7 @@ Check out our [React Native Guides](https://developer.bitmovin.com/playback/docs ### Sample Application In the [/example/](https://github.com/bitmovin/bitmovin-player-react-native/tree/development/example) folder you can find a sample application showcasing many of the features of the Player React Native SDK. +See the related [README.md](https://github.com/bitmovin/bitmovin-player-react-native/tree/development/example/README.md) for more information on how to get started with the sample application. ## Maintenance and Updates diff --git a/example/README.md b/example/README.md index 607cf0e2..e3fb1293 100644 --- a/example/README.md +++ b/example/README.md @@ -1,6 +1,6 @@ -# Example +# Example Application -This is a React Native app built to showcase the features of `bitmovin-player-react-native`. The code for all feature samples is contained +This is a React Native application built to showcase the features of `bitmovin-player-react-native`. The code for all feature samples is contained inside the [`src/screens/`](https://github.com/bitmovin/bitmovin-player-react-native/tree/development/example/src/screens) directory: - [Basic playback](https://github.com/bitmovin/bitmovin-player-react-native/blob/development/example/src/screens/BasicPlayback.tsx) @@ -24,16 +24,16 @@ To play back a custom video asset, it is possible to set up a simple playback se ## Getting started -To get started with the project, run `yarn bootstrap` in the lib's root directory (not `example/`). This will install dependencies for both the library and the example app (as well as native deps too): +To get started with the project, run `yarn bootstrap` in the library's root directory (not `example/`). This will install dependencies for both the library and the example application (as well as native dependencies): ```sh -cd bitmovin-player-react-native # Go to lib's root directory +cd bitmovin-player-react-native # Go to library's root directory yarn bootstrap # Install all dependencies ``` ## Configuring your license key -Before running the app, make sure to set up your Bitmovin's license key in the native metadata file of each platform: +Before running the application, make sure to set up your Bitmovin's license key in the native metadata file of each platform: **iOS** @@ -63,15 +63,29 @@ const player = usePlayer({ }); ``` -## Running the app +### Add the Package Name and Bundle Identifiers as an Allowed Domain -First start the metro bundler by running the following command on the lib's root (always execute `yarn` from the lib's root): +Add the following package names and bundle identifiers of the example applications ending as an allowed domain on [https://bitmovin.com/dashboard](https://bitmovin.com/dashboard), under `Player -> Licenses` and also under `Analytics -> Licenses`. -```sh -yarn example start # Starts bundler on the example folder +#### Android example application Package Name + +``` +com.bitmovin.player.reactnative.example +``` + +#### iOS example application Bundle Identifier + +``` +com.bitmovin.PlayerReactNative-Example ``` -Then run it via terminal or an IDE (Xcode/Android Studio): +#### tvOS example application Bundle Identifier + +``` +com.bitmovin.PlayerReactNativeExample-tvOS +``` + +## Running the application **Terminal** @@ -89,3 +103,13 @@ yarn example ios --simulator="iPhone 14 Pro" **IDE** You can also open the iOS project using Xcode by typing `xed example/ios/` on terminal, or `studio example/android/` to open the android project in Android Studio (make sure to setup its binaries first). + +### Running the bundler only + +The bundler is automatically started when running `yarn example android` or `yarn example ios` or when running via the IDEs, but it can also be started separately. + +To start the metro bundler, run the following command on the library's root (always execute `yarn` from the library's root): + +```sh +yarn example start # Starts bundler on the example folder +``` From 7d8ce3947a981c9b9ab238d8e4f54d8b65163679 Mon Sep 17 00:00:00 2001 From: Update Bot Date: Mon, 19 Feb 2024 13:36:29 +0000 Subject: [PATCH 7/8] chore(ios): update ios player version to 3.56.2 --- RNBitmovinPlayer.podspec | 2 +- example/ios/Podfile.lock | 14 +++++++------- integration_test/ios/Podfile.lock | 14 +++++++------- 3 files changed, 15 insertions(+), 15 deletions(-) diff --git a/RNBitmovinPlayer.podspec b/RNBitmovinPlayer.podspec index 910c4931..4a7d8e39 100644 --- a/RNBitmovinPlayer.podspec +++ b/RNBitmovinPlayer.podspec @@ -19,7 +19,7 @@ Pod::Spec.new do |s| s.source_files = "ios/**/*.{h,m,mm,swift}" s.dependency "React-Core" - s.dependency "BitmovinPlayer", "3.56.1" + s.dependency "BitmovinPlayer", "3.56.2" s.ios.dependency "GoogleAds-IMA-iOS-SDK", "3.18.4" s.tvos.dependency "GoogleAds-IMA-tvOS-SDK", "4.8.2" end diff --git a/example/ios/Podfile.lock b/example/ios/Podfile.lock index 48c9e326..d189a579 100644 --- a/example/ios/Podfile.lock +++ b/example/ios/Podfile.lock @@ -3,10 +3,10 @@ PODS: - BitmovinAnalyticsCollector/Core - BitmovinPlayerCore (~> 3.48) - BitmovinAnalyticsCollector/Core (3.5.0) - - BitmovinPlayer (3.56.1): + - BitmovinPlayer (3.56.2): - BitmovinAnalyticsCollector/BitmovinPlayer (~> 3.0) - - BitmovinPlayerCore (= 3.56.1) - - BitmovinPlayerCore (3.56.1) + - BitmovinPlayerCore (= 3.56.2) + - BitmovinPlayerCore (3.56.2) - boost (1.76.0) - DoubleConversion (1.1.6) - FBLazyVector (0.72.6-1) @@ -424,7 +424,7 @@ PODS: - React-logger (= 0.72.6-1) - React-perflogger (= 0.72.6-1) - RNBitmovinPlayer (0.17.0): - - BitmovinPlayer (= 3.56.1) + - BitmovinPlayer (= 3.56.2) - GoogleAds-IMA-iOS-SDK (= 3.18.4) - GoogleAds-IMA-tvOS-SDK (= 4.8.2) - React-Core @@ -592,8 +592,8 @@ EXTERNAL SOURCES: SPEC CHECKSUMS: BitmovinAnalyticsCollector: 8b9a4b07f1fa2a43996ba29598eab6f50a25edfe - BitmovinPlayer: 567750b902de8d7234fa80c9c41349adca47e845 - BitmovinPlayerCore: 62abf17a7df2a35fc20fd8f29ad388c1388f32b8 + BitmovinPlayer: d90e291619495dafd0708d7e228bac687a8f7add + BitmovinPlayerCore: a1c24e70af1417ccc20c780d938ad116305d685e boost: 43f331345fd5d44b60bf621e7e579ae7b8fda687 DoubleConversion: 234abba95e31cc2aada0cf3b97cdb11bc5b90575 FBLazyVector: 58c22987e2cd1eebb2e3bc9f7756d87b14c32d3c @@ -639,7 +639,7 @@ SPEC CHECKSUMS: React-runtimescheduler: acd6b708338a975a9bb4c594eac0f018f5c15fa3 React-utils: c1cf85c0cd58c11dfb95104a78c608e95d03eb9e ReactCommon: 1dabb8f37c44d8c7370238bd8f504cbad0cfd941 - RNBitmovinPlayer: fe0befae771204c4f9f60fb43745812922a21024 + RNBitmovinPlayer: 6b6f43794fa782dc3ccc8d72d46d89b33cde4cb6 RNCPicker: 529d564911e93598cc399b56cc0769ce3675f8c8 RNScreens: 4a1af06327774490d97342c00aee0c2bafb497b7 SocketRocket: f32cd54efbe0f095c4d7594881e52619cfe80b17 diff --git a/integration_test/ios/Podfile.lock b/integration_test/ios/Podfile.lock index 26a284d6..4288173b 100644 --- a/integration_test/ios/Podfile.lock +++ b/integration_test/ios/Podfile.lock @@ -3,10 +3,10 @@ PODS: - BitmovinAnalyticsCollector/Core - BitmovinPlayerCore (~> 3.48) - BitmovinAnalyticsCollector/Core (3.5.0) - - BitmovinPlayer (3.56.1): + - BitmovinPlayer (3.56.2): - BitmovinAnalyticsCollector/BitmovinPlayer (~> 3.0) - - BitmovinPlayerCore (= 3.56.1) - - BitmovinPlayerCore (3.56.1) + - BitmovinPlayerCore (= 3.56.2) + - BitmovinPlayerCore (3.56.2) - boost (1.76.0) - DoubleConversion (1.1.6) - FBLazyVector (0.72.6-1) @@ -413,7 +413,7 @@ PODS: - React-logger (= 0.72.6-1) - React-perflogger (= 0.72.6-1) - RNBitmovinPlayer (0.17.0): - - BitmovinPlayer (= 3.56.1) + - BitmovinPlayer (= 3.56.2) - GoogleAds-IMA-iOS-SDK (= 3.18.4) - GoogleAds-IMA-tvOS-SDK (= 4.8.2) - React-Core @@ -560,8 +560,8 @@ EXTERNAL SOURCES: SPEC CHECKSUMS: BitmovinAnalyticsCollector: 8b9a4b07f1fa2a43996ba29598eab6f50a25edfe - BitmovinPlayer: 567750b902de8d7234fa80c9c41349adca47e845 - BitmovinPlayerCore: 62abf17a7df2a35fc20fd8f29ad388c1388f32b8 + BitmovinPlayer: d90e291619495dafd0708d7e228bac687a8f7add + BitmovinPlayerCore: a1c24e70af1417ccc20c780d938ad116305d685e boost: 43f331345fd5d44b60bf621e7e579ae7b8fda687 DoubleConversion: 234abba95e31cc2aada0cf3b97cdb11bc5b90575 FBLazyVector: 58c22987e2cd1eebb2e3bc9f7756d87b14c32d3c @@ -602,7 +602,7 @@ SPEC CHECKSUMS: React-runtimescheduler: acd6b708338a975a9bb4c594eac0f018f5c15fa3 React-utils: c1cf85c0cd58c11dfb95104a78c608e95d03eb9e ReactCommon: 1dabb8f37c44d8c7370238bd8f504cbad0cfd941 - RNBitmovinPlayer: fe0befae771204c4f9f60fb43745812922a21024 + RNBitmovinPlayer: 6b6f43794fa782dc3ccc8d72d46d89b33cde4cb6 SocketRocket: f32cd54efbe0f095c4d7594881e52619cfe80b17 Yoga: f67f5769ce78049c5fe798bc735f04535c7bc1ac From 6909f3067b16c01169399f5d9f58b0ff3350e3a7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Roland=20K=C3=A1konyi?= Date: Tue, 27 Feb 2024 10:12:41 +0100 Subject: [PATCH 8/8] Update CODEOWNERS with owners for .github folder --- .github/CODEOWNERS | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 8dad8ce0..c2038b0a 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1,3 +1,4 @@ +.github/ @bitmovin/player-ios @bitmovin/player-android ios/ @bitmovin/player-ios example/ios/ @bitmovin/player-ios android/ @bitmovin/player-android