Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove signers from bdk_wallet #1619

Open
1 of 4 tasks
notmandatory opened this issue Sep 20, 2024 · 0 comments
Open
1 of 4 tasks

Remove signers from bdk_wallet #1619

notmandatory opened this issue Sep 20, 2024 · 0 comments
Labels
api A breaking API change module-wallet
Milestone
2.0.0

Comments

@notmandatory
Copy link
Member

notmandatory commented Sep 20, 2024 •
edited by ValuedMammal
Loading

Describe the enhancement

This is a tracking issue to remove signing capabilities from Wallet and provide a new way to sign and finalize PSBTs using rust-bitcoin Psbt::sign and implementing the GetKey trait for relevant types. Please comment below or mention this issue in related issues and PRs.

Use case

Safer and more flexible approaches to signing PSBTs can be done outside of the Wallet type.

Additional context
@notmandatory notmandatory added the api A breaking API change label Sep 20, 2024
@notmandatory notmandatory added this to the 2.0.0 milestone Sep 20, 2024
@notmandatory notmandatory added this to BDK Sep 20, 2024
@notmandatory notmandatory moved this to Todo in BDK Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api A breaking API change module-wallet
Projects
BDK
Status: Todo
Milestone
2.0.0
Development

No branches or pull requests
1 participant
@notmandatory