Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using tokio-postgres in place of sqlx #2

Open
ValuedMammal opened this issue Aug 23, 2024 · 4 comments
Open

Consider using tokio-postgres in place of sqlx #2

ValuedMammal opened this issue Aug 23, 2024 · 4 comments

Comments

@ValuedMammal
Copy link
Collaborator

And possibly renaming the crate along the lines of "bdk_postgres".

@tvpeter
Copy link

tvpeter commented Sep 11, 2024

@ValuedMammal I would like to work on this.

@ValuedMammal
Copy link
Collaborator Author

Yeah it might be worth looking into. One thing to keep in mind is that this library should still work with any existing apps that use sqlx, so if moving to tokio-postgres causes any sort of dependency clash that could be a problem.

@tvpeter
Copy link

tvpeter commented Sep 11, 2024

From an initial consideration, the Error::Sqlx will result in a breaking change. Except we consider returning errors from queries as Error::Sqlx.

@matthiasdebernardini
Copy link
Collaborator

I'm ok with that, the current error handling from sqlx is not that useful because when it fails it doesn't say which query fails, it just says the reason why. I have no problem with the error types changing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants