Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal: tab auto-complete doesn't correct folder casing #1708

Open
alainbryden opened this issue Oct 20, 2024 · 1 comment
Open

Terminal: tab auto-complete doesn't correct folder casing #1708

alainbryden opened this issue Oct 20, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@alainbryden
Copy link
Contributor

Steps to reproduce:

  1. Have a folder created with upper-case letters, such as "Tasks/", and some scripts in this folder.
    image

  2. Type the folder name incorrectly as all-lower-case ("tasks/") then proceed to tab-autocomplete a file name.
    Note that the auto-complete will correct the case of the filename if you typed any letters in the incorrect case, but it will not correct the case of the folder name:
    image

  3. This will now open a new file (in a new folder) rather than the existing file you tab-auto-completed:
    image

Acceptable solutions (IMO):

  • Correct the casing in the full path (including folder name) when we tab-autocomplete - currently we just correc the filename casing.
    or
  • Once the folder name has been completed ("/" is present in the path) - tab auto-complete should no longer list any files, because the folder does not exist. Specifically, it should not list files that exist in a similarily-named folder, but with different casing.

A side-effect of the current behaviour (ignoring folder casing when auto-completing) is that if the user creates two folders with the same name but different casing, these folders are merged in the auto-complete box. In this case, since each folder now has a file named "backdoor-all-servers.js", this entry appears twice:
image

@gmcew gmcew added the bug Something isn't working label Oct 23, 2024
@gmcew
Copy link
Collaborator

gmcew commented Oct 24, 2024

For reference for any potential PR on this; there's a few other autocomplete problems at #522 and #1473 which may be worth considering. As far as I can see this is the first issue referencing automplete's case-sensitivity, though I might have missed a previous mention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants