DOCUMENTATION: Insufficient alternative for ns.go.analysis.getValidMoves()

[bupjae]

Currenr dev branch

bitburner-src/markdown/bitburner.goanalysis.getvalidmoves.md

Line 26 in 23f98c1

RAM cost: 8 GB (This is intentionally expensive; you can derive this info from just getBoardState() )

We also have to determine getMoveHistory() to comply no-repeat rule.

bitburner-src/src/Go/boardAnalysis/boardAnalysis.ts

Lines 46 to 47 in 23f98c1

	// Detect if the move might be an immediate repeat (only one board of history is saved to check)
	const possibleRepeat = boardState.previousBoards.find((board) => getColorOnBoardString(board, x, y) === player);

The comment says only one board of history is checked, but the code actually checks full history.

[d0sboots]

You might want to open this as either an issue or a PR, commenting on the repo will get lost.

[bupjae]

I think I just created (= open?) the issue, including current repo as link.

I didn't know it is possible to comment on the repo directly.

[d0sboots]

Oh weird, this is an issue. I was just brain-farting when looking at it.

Yeah, it is possible to comment on the repo directly. I'm not sure how, but I've seen it done by someone in a different repo that I have notifications on. XD

[ficocelliguy]

@bupjae I see that the documentation needs to be updated. However, I'm not sure I understand the title of the issue "Insufficient alternative for ns.go.analysis.getValidMoves()". Is there some other state access you are looking for that would help with what you are doing?

(You are correct, the player will need to keep track of the move history themselves to fully replace getValidMoves(), and the docs should say that )