-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Apple Silicon and Big Sur #15
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified that it works as intended on M1 and Big Sur 🚀
It's also working for me on a Mac mini M1 (macOS Big Sur Version 11.2.3 (29D91) 🥳 Thanks @msanders! |
This should get merged someday! |
DESTINATION = /usr/local/lib/pam | ||
TARGET = x86_64-apple-macosx10.15 | ||
TARGET = apple-darwin20.1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may have to resolve the target value from the system:
TARGET = $(swift -version)
Is this enough to work across different chip sets?
I had to update the TARGET for macOS 11.4
I also had to manually add write permissions to the
Then I was able to complete the install steps successfully:
|
I think the |
The target flag is required to make a universal binary so it can work under Rosetta. You can reproduce the above error with:
|
The latest version of macOS,
|
Closes biscuitehh#15, closes biscuitehh#20. Resolves biscuitehh#7, resolves biscuitehh#14, resolves biscuitehh#16, resolves biscuitehh#17.
Closes biscuitehh#15, closes biscuitehh#20. Resolves biscuitehh#7, resolves biscuitehh#14, resolves biscuitehh#16, resolves biscuitehh#17.
Partially supersedes biscuitehh#20. Closes biscuitehh#15. Resolves biscuitehh#7, resolves biscuitehh#14, resolves biscuitehh#16, resolves biscuitehh#17.
Partly taken from upstream in Reflejo#18.
It's necessary to create a universal binary to avoid the following error when a program running in Rosetta invokes sudo:
Fixes #7.