-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecate flyingpigeon #376
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve the intent.
E2E Test ResultsDACCS-iac Pipeline ResultsBuild URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/1976/Result : failure BIRDHOUSE_DEPLOY_BRANCH : deprecate-flyingpigeon DACCS_CONFIGS_BRANCH : master PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master PAVICS_SDI_BRANCH : master DESTROY_INFRA_ON_EXIT : true PAVICS_HOST : https://host-140-67.rdext.crim.ca PAVICS-e2e-workflow-tests Pipeline ResultsTests URL : http://daccs-jenkins.crim.ca:80/job/PAVICS-e2e-workflow-tests/job/master/1271/NOTEBOOK TEST RESULTS |
Ouranosinc/pavics-sdi#303 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR itself is good.
Needs updates to test suite as mentioned by @huard
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. This is a direct rename from config/flyingpigeon/
to deprecated-components/flyingpigeon/
so should be slow risk.
E2E Test ResultsDACCS-iac Pipeline ResultsBuild URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/1991/Result : failure BIRDHOUSE_DEPLOY_BRANCH : deprecate-flyingpigeon DACCS_CONFIGS_BRANCH : master PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master PAVICS_SDI_BRANCH : master DESTROY_INFRA_ON_EXIT : true PAVICS_HOST : https://host-140-35.rdext.crim.ca PAVICS-e2e-workflow-tests Pipeline ResultsTests URL : http://daccs-jenkins.crim.ca:80/job/PAVICS-e2e-workflow-tests/job/master/1276/NOTEBOOK TEST RESULTS |
Ran the weaver notebook against an instance deployed with bird-house/birdhouse-deploy#376 to obtain the response outputs without `flyingpigeon` processes, and replaced back the `PAVICS_FQDN` value by the original one in the notebook. - relates to #303 - relates to bird-house/birdhouse-deploy#376
E2E Test ResultsDACCS-iac Pipeline ResultsBuild URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/2050/Result : failure BIRDHOUSE_DEPLOY_BRANCH : deprecate-flyingpigeon DACCS_CONFIGS_BRANCH : master PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master PAVICS_SDI_BRANCH : master DESTROY_INFRA_ON_EXIT : true PAVICS_HOST : https://host-140-20.rdext.crim.ca PAVICS-e2e-workflow-tests Pipeline ResultsTests URL : http://daccs-jenkins.crim.ca:80/job/PAVICS-e2e-workflow-tests/job/master/1301/NOTEBOOK TEST RESULTS |
E2E Test ResultsDACCS-iac Pipeline ResultsBuild URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/2053/Result : failure BIRDHOUSE_DEPLOY_BRANCH : deprecate-flyingpigeon DACCS_CONFIGS_BRANCH : master PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master PAVICS_SDI_BRANCH : master DESTROY_INFRA_ON_EXIT : true PAVICS_HOST : https://host-140-20.rdext.crim.ca Infrastructure deployment failed. Instance has not been destroyed. @matprov |
Error due to left over template configs not ignored: ❯ git status
On branch master
Your branch is up to date with 'origin/master'.
Untracked files:
(use "git add <file>..." to include in what will be committed)
birdhouse/config/flyingpigeon/
nothing added to commit but untracked files present (use "git add" to track) |
@mishaschwartz @tlvu |
…ated-components (relates to #376)
…ated-components (#380) ## Overview Avoid git dirty working directory from deprecated flyingpigeon configurations generated from templates that could remain. Ignore template files causing a problem after #376 update. ## Changes **Non-breaking changes** - Fix invalid templated configurations of `flyingpigeon` that could remain in the old location (`birdhouse/config/flyingpigeon`) when updating an existing instance to `1.31.0`. **Breaking changes** - n/a ## Related Issue / Discussion - Resolves #376 (comment)
@fmigneault our production include this PR and it is fine
|
@tlvu Thanks for confirming. Maybe just a sporadic error on our side. |
Sorry this is not true. I just pulled this in. Will force the deploy and re-test. |
@fmigneault it stills works
|
I can confirm ours still works as well:
|
Overview
Deprecate the
flyingpigeon
web processing serviceChanges
Non-breaking changes
DEFAULT_CONF_DIRS
list and moves its config files to thedeprecated-components
directoryBreaking changes
EXTRA_CONF_DIRS
listRelated Issue / Discussion
Additional Information
Links to other issues or sources.