-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jupyterhub: allow users created before Cowbird was enabled to spawn jupyterlab #480
base: master
Are you sure you want to change the base?
Conversation
@tlvu please test this in your staging environment to ensure that this works for all of your users who were created before cowbird was enabled by default (version 2.0) |
@mishaschwartz great ! Will test this next week. By the way, do you plan to roll all changes to make Cowbird compatible with existing Magpie users and the poor-man sharing into one PR? Basically all the work-around found in #425, whenever they make sense and is possible of course. |
The workaround described here #425 (comment) can be enabled just by updating your env.local file. I don't think there are any additional code changes that are needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for the fix!
I'll let @tlvu do a more in-depth test to validate.
Check out #481 which adds better documentation to avoid this for other users in the future. |
Right sorry, I forgot all the work-around are just configs in |
Overview
Users created before Cowbird was enabled will not have a "workspace directory" created. A workspace directory is a symlink to the directory that contains their Jupyterhub data.
When Cowbird is enabled, Jupyterhub checks if the workspace directory exists and raises an error if it doesn't.
This change allows Jupyterhub to create the symlink if it doesn't exist instead of raising an error.
This means that users without a "workspace directory" will be able to continue using Jupyterhub as they did before without the need for manual intervention by a system administrator who would otherwise need to manually create the symlink for them.
Changes
Non-breaking changes
Breaking changes
None
Related Issue / Discussion
Additional Information
CI Operations
birdhouse_daccs_configs_branch: master
birdhouse_skip_ci: false