Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is_mmstack is required but tifffile dependency is older #22

Open
toloudis opened this issue Sep 20, 2024 · 1 comment
Open

is_mmstack is required but tifffile dependency is older #22

toloudis opened this issue Sep 20, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@toloudis
Copy link

Describe the Bug

this plugin uses tifffile's is_mmstack parameter but that parameter was only added after our minimum tifffile dependency requirement

Expected Behavior

consistency of dependency version with implementation

From Filip:

File "/home/filip.sluzewski/.pyenv/versions/3.10.14/envs/trackastra/lib/python3.10/site-packages/bioio_tifffile/reader.py", line 463, in _read_delayed
    with TiffFile(open_resource, is_mmstack=False) as tiff:
  File "/home/filip.sluzewski/.pyenv/versions/3.10.14/envs/trackastra/lib/python3.10/site-packages/tifffile/tifffile.py", line 3928, in __init__
    raise TypeError(f'unexpected keyword argument: {key}')
TypeError: unexpected keyword argument: is_mmstack

...

pip freeze | grep tiff
bioio-ome-tiff==1.0.0
bioio-tifffile==1.0.0
tifffile==2023.2.28
@toloudis toloudis added the bug Something isn't working label Sep 20, 2024
@toloudis
Copy link
Author

v2023.3.15 seems to be the first where is_mmstack shows up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant