Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document precision losses in metadata/etc. for standalone Qurro #293

Open
fedarko opened this issue Mar 14, 2020 · 0 comments
Open

Document precision losses in metadata/etc. for standalone Qurro #293

fedarko opened this issue Mar 14, 2020 · 0 comments
Labels
bug Something isn't working docs README, tutorials, demos, etc. external issues/bugs with other libraries, frameworks, etc.; might include reproducing an issue minimally

Comments

@fedarko
Copy link
Collaborator

fedarko commented Mar 14, 2020

This likely impacts other stuff besides the metadata that gets "sent" from python to JS.

As an example of this "issue," consider feature fe98555e63f547c33b3987391cd34d5d in the Q2 moving pictures data. It has a Confidence of 0.9993999015917799, but here's the weird thing: in the Q2 Qurro visualization of the moving pictures data, this confidence value shows up correctly in the DataTable when this feature is selected. In the standalone Qurro visualization of this same data, this instead shows up as 0.99939990159178 (rounded off at the end).

If you count it out, this rounded-off value is exactly 16 characters long, which seems like it's probably relevant to this problem (maybe this is a pd.read_csv() thing? It should be reading everything in as strings at first, but you never know).

This is such a minor issue that I doubt it will impact anyone, but it would be good to address this problem -- and/or document why it's happening. Some imprecision is to be expected (see: how JS breaks with > ~2^53 values or something), but it's good to quantify this wherever possible.

@fedarko fedarko added bug Something isn't working external issues/bugs with other libraries, frameworks, etc.; might include reproducing an issue minimally docs README, tutorials, demos, etc. labels Mar 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docs README, tutorials, demos, etc. external issues/bugs with other libraries, frameworks, etc.; might include reproducing an issue minimally
Projects
None yet
Development

No branches or pull requests

1 participant