-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove native-base #33
Comments
We have three options of doing this:
Personally I see pros and cons of every solution but my favorite is the second one. |
In order to structure the thread and discussion somehow, I propose that the potential solutions be presented in the form of a table with pros and cons. This will make it easier to make a decision once these key solutions have been analyzed. So to start without investigating on any specific solution, rather general one: 1. Component Libraries
2. Config/Helper Libraries
3. Creating Everything On Our Own
I would go for option 3, as we can rely on a large and experienced team which would allow us to minimise the risk of over-engineering. And, in my opinion, the much greater time required to implement this solution would pay off in the future, if only by building the organisation's own brand as well as that of the developers working on the library. |
Thank you for this detailed overview, you are right creating everything on our own will be much better, I'm only thinking if this will be easier in use for development in feature projects. We need to support at least two themes (dark / light) and web app, so we need to come up with some good solution to solve all this challenges, and make the development of the app easy :D Let me think about it couple of days and I will back with my thoughts. |
I was thinking about it and I'm still not 100% sure that implementing all of it for our self will be the best idea. I know that creating atom components like @MSzalowski |
@MateuszRostkowski You are right. |
@MSzalowski Maybe we will create our own wrapper and it will work like this: import { View, Image } from 'react-native'
const Box = generateStyledComponent(View)
{...}
<Box
pt={4}
bg="primary"
/>
const Row = generateStyledComponent(View, {
flexDirection: 'row'
})
{...}
<Row
pt={4}
bg="primary"
/> And then developer can create their own components like: import { Image } from 'expo-image'
const StyledImage = generateStyledComponent(Image)
{...}
<StyledImage
mx={4}
/> |
Linked pull request includes import updates of native-base. |
Right now we are using native base and maintainers of the native base are abandoning the support for this library.
That means we need to find other alternative and use it in the template.
The text was updated successfully, but these errors were encountered: