fix es6 tsc checks complaining on newer s regex flag #2938
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
gitlab pipeline seems to be reporting tsc error
removing the s from the regex fixes the issue along with updating the regex to not need this flag by having [\s\S] which is all characters including newline which "." does not include unless you add the newer s flag to the regex which is only supported in 2018+ browsers.
Alternative solution is to change package.json type-check line to target es2018 or newer
Corresponding issue:
#2781
Testing
Ran though all head-support extension manual tests to make sure they work as expected after regex change as well as manually testing regex change in JS console
Checklist
master
for website changes,dev
forsource changes)
approved via an issue
npm run test
) and verified that it succeeded