Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contrast inversion #131

Closed
martinschorb opened this issue May 13, 2020 · 2 comments
Closed

Contrast inversion #131

martinschorb opened this issue May 13, 2020 · 2 comments

Comments

@martinschorb
Copy link
Collaborator

Is there an easy way to invert the contrast?

I could not manage with setting the min and max sliders to opposite values. It does some value flips and looks weird.
@NicoKiaru
Copy link
Collaborator

Yes, flipping min and max works with RealLUTConverter but not with the standard ColorConverter. This would indeed be an easy way to inverse the contrast, and I don't know the reason why it doesn't work. It's more a question for @tpietzsch , if he has some time.

@NicoKiaru NicoKiaru mentioned this issue May 6, 2021
Merged
NicoKiaru added a commit that referenced this issue May 7, 2021
@NicoKiaru
Merge pull request #219 from bigdataviewer/refactor_display_options
359a143 
Refactor display options

Heaving refactoring. A lot of the display customization is removed from this repository and goes into https://github.com/NicoKiaru/bigdataviewer_playground_display. We get a better separation of tasks, the same functionalities as before, and an easier and more flexible to extend them.

This PR allows to solve, or provide an easier way to fix:

    #199 -> done in bigdataviewer_playground_display
    #196 -> done in bigdataviewer_playground_display with more flexibility
    #140
    #136
    #131
    #117
    #95
    #94

Two main mecahnisms used to separates concerns:
* using more scijava plugins extensibility mechanism
* using gson serialization, in combination with scijava plugins

This  allows in particular  the serialization of the suppliers of Bdv windows. User prefs (and dev prefs) are stored conveniently in the class that builds bdv windows, and is stored through serialization.

Another kind of plugin is added, which allows to handle any sourceandconverter operation based on a tag of xml of spimdata objects, when spimdata objects are loaded or saved ( think displaysettings, projection, and also custom converters for label images).
@NicoKiaru NicoKiaru mentioned this issue Dec 16, 2021
Open
@NicoKiaru
Copy link
Collaborator

See bigdataviewer/bigdataviewer-core#187 to follow up on this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@NicoKiaru @martinschorb