Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add newline to the end of the translation files #224

Open
smnbbrv opened this issue Jan 7, 2021 · 6 comments
Open

Add newline to the end of the translation files #224

smnbbrv opened this issue Jan 7, 2021 · 6 comments

Comments

@smnbbrv
Copy link

smnbbrv commented Jan 7, 2021

Hi @biesbjerg ,

I constantly hit a very simple-to-fix issue.

The .editorconfig forces IDE to add a new line in the end of the file, and the regenerate command removes this newline.

So, git thinks something is updated although nothing really is.

Could it be added by default / as a configuration parameter?

To be more precise. This is what is currently generated:

{
  "token": "value"
}

and this is desired output

{
  "token": "value"
}
<-- newline here
@smnbbrv
Copy link
Author

smnbbrv commented Mar 29, 2021

@ghost683 this is good for Linux-like OS, but is not applicable to e.g. Windows. I still believe this should be provided by the tool itself

@ghost683
Copy link

ghost683 commented Mar 29, 2021

i'm not sure, i'am not on project, but some time ago I had the same need and i solved it as well, otherwise you coul'd try
"echo >> file.txt".
https://stackoverflow.com/questions/23055831/add-new-line-character-at-the-end-of-file-in-bash

@smnbbrv
Copy link
Author

smnbbrv commented Mar 29, 2021

@ghost683 you are right, there are tons of ways to deal with this. But this issue is not about workaround, it's about the feature that is missing in 99% of the projects

@ghost683
Copy link

i know, it was just a suggestion, i solved it like this

@johncardiologs
Copy link

It seems this issue would be closed by #204

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants