Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSV lookup tables for segmentation do not allow extra columns #1993

Open
Remi-Gau opened this issue Nov 28, 2024 · 2 comments
Open

TSV lookup tables for segmentation do not allow extra columns #1993

Remi-Gau opened this issue Nov 28, 2024 · 2 comments

Comments

@Remi-Gau
Copy link
Collaborator

See here:

https://bids-specification.readthedocs.io/en/latest/derivatives/imaging.html#common-image-derived-labels

Image

Is there a reason for this?

For context I am trying to use this to help standardize the atlases in nilearn and adding some extra columns would be handy.

@Remi-Gau
Copy link
Collaborator Author

@effigies forgot to ask you about this one yesterday?

@effigies
Copy link
Collaborator

effigies commented Dec 13, 2024

I doubt it:

SegmentationLookup:
selectors:
- dataset.dataset_description.DatasetType == "derivative"
- intersects([suffix], ["dseg", "probseg"])
columns:
index: required
name__segmentations: required
abbreviation: optional
color: optional
mapping: optional
index_columns: [index]

We have no additional_columns field, so it's presumably defaulting to not allowed. IMO we should probably default to allowed, and in any event I don't see any reason not to allow (or at least "allowed_if_defined") this one.

cc @rwblair for thoughts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants