Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unit-tests are functionally useless due to Youtube anti-rip tech #340

Open
vxbinaca opened this issue Nov 13, 2024 · 1 comment
Open

unit-tests are functionally useless due to Youtube anti-rip tech #340

vxbinaca opened this issue Nov 13, 2024 · 1 comment

Comments

@vxbinaca
Copy link
Collaborator

vxbinaca commented Nov 13, 2024

We need to move away from unit tests on sites with anti-ripping policies.

So no using sites like:

  • Youtube - I mean it no youtube their anti-rip policies broke our unit tests.

  • Vimeo - intermittent rip prevention not reliable for unit tests.

  • TikTok - MOST aggressive rip prevention

  • Instagram - High level of rip prevention

  • Pornhub - intermittent rip prevention not reliable for unit tests.

  • X - intermittent rip prevention not reliable for unit tests.

  • Any site that throttles you and you need auth or cookies to bypass rate limits or IP bans

  • Kick channel ingestion is currently broken in yt-dlp

  • Twitch is a giant churning mass of deleted videos and banned accounts.

Video also needs to have open license, site needs to provide metadata from a player that is supported by yt-dlp because we don't want to end up like youtube-dl was a few years back ripping a Taylor Swift video in their unit tests. No direct links to a random .mp4 file. We need a youtube-like site that doesn't rip throttle.

@orkeilius
Copy link

Like I say in the commit comment, you could use unit test integrated mocking system to mock yt-dlp module.
Like you already do with request-mock, instead of testing yt-dlp you just send the expected result when a yt-dlp function is call

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants