Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The optimization step : set_epsilon #46

Open
yuvrajiro opened this issue May 30, 2023 · 0 comments
Open

The optimization step : set_epsilon #46

yuvrajiro opened this issue May 30, 2023 · 0 comments

Comments

@yuvrajiro
Copy link

The set_epsilon function in original COBRA implementation uses grid search cv to get the best $\epsilon$ on the dataset X_epsilon, y_epsilon, which fits and predicts on X_epsilon and y_epsilon; I do not think this is the correct way to do this, I have read the original COBRA paper carefully and have read its implementation on CRAN Package by authors, archived version is available here

The problem with the current implementation is it takes general $\epsilon$. Still, if we take a careful look at the paper, it is $\epsilon_l$, not $\epsilon$, it means that $\epsilon_l$ is specific for a selected $D_l$, so if we change $D_l$ the optimal $\epsilon_l$ will be different, in that way may be cross-validation will not work here.

In the original implementation on CRAN, they first take set $D_{k}$, $D_{l}$, $D_{val}$ and $D_{test}$ then to get a prediction on $D_{test}$, did the following steps :

  1. Train initial machine on $D_k$
  2. Get a prediction of the initial machine on $D_l$
  3. Set $\epsilon_l$ and $\alpha$, by grid search for the best quadratic error on $D_{val}$
  4. then get the prediction on $D_{test}$ based upon the best best $\epsilon_l$, choose in step 3

Let me know, If I understand correctly (or incorrectly); I am working on using the $D_{val}$ to be attached in $D_l$ or $D_k$ so that it will get more data points and give better results for that $\epsilon_l$ needs to be changed accordingly, let me know if anyone wants to work in collaboration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant