Skip to content

Commit

Permalink
Remove explict go toolchain versions (flyteorg#5723)
Browse files Browse the repository at this point in the history
- flyteorg#5032 updated builds to use
   Go 1.22 -- but in practice it looks like flytectl is being built with
   an outdated toolchain based on Go 1.22.0 instead of Go 1.22.5 or
   1.22.6 (i.e. latest)

   See https://go.dev/doc/toolchain for further details

   For instance, flytectl v0.9.0 reports being built with Go 1.22.0

   ❯ go version -m -v flytectl
   flytectl: go1.22.0

   Ensure the proper Go environment for security reasons

Signed-off-by: ddl-ebrown <[email protected]>
Signed-off-by: Bugra Gedik <[email protected]>
  • Loading branch information
ddl-ebrown authored and bgedik committed Sep 12, 2024
1 parent f30613b commit cee4e16
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 4 deletions.
2 changes: 0 additions & 2 deletions datacatalog/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@ module github.com/flyteorg/flyte/datacatalog

go 1.22

toolchain go1.22.1

require (
github.com/Selvatico/go-mocket v1.0.7
github.com/flyteorg/flyte/flyteidl v0.0.0-00010101000000-000000000000
Expand Down
2 changes: 0 additions & 2 deletions flytectl/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@ module github.com/flyteorg/flyte/flytectl

go 1.22

toolchain go1.22.0

require (
github.com/apoorvam/goterminal v0.0.0-20180523175556-614d345c47e5
github.com/avast/retry-go v3.0.0+incompatible
Expand Down

0 comments on commit cee4e16

Please sign in to comment.