Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to run lint against a subset of changes #262

Open
jacobbednarz opened this issue Jan 14, 2023 · 0 comments
Open

Ability to run lint against a subset of changes #262

jacobbednarz opened this issue Jan 14, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@jacobbednarz
Copy link

jacobbednarz commented Jan 14, 2023

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

I maintain an older provider that relies on tfprovidferlint however, I have to disable some of the more useful checks due to large parts of the codebase not ever being touched. While we have a plan to address these older parts, I'd still like to find a way to run all the lint rules on new code to prevent those problems creeping in.

This would be a similar request to golanglint-ci's new or new-from-rev configuration - https://golangci-lint.run/usage/configuration/.

I used to have a workaround that relied on git diff-tree, matching all the files that changed between commits and making sure we loaded all the base files however, that got pretty unmanageable. So I thought it's time to see if there is a way to include this in the tool itself.

New or Affected Checks(s)

n/a

Flagged Provider Code

n/a

Passing Provider Code

n/a

References

Could potentially use build tags (as mentioned in #257) if they worked.

@jacobbednarz jacobbednarz added the enhancement New feature or request label Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant