New Check: helper/resource.TestStep Should Omit Destroy Field with Default Value

[bflad]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Declaring a TestStep with Destroy: false is extraneous and can be confusing for those not familiar with the acceptance testing framework.

New Check

• AT###

Flagged Provider Code

resource.TestStep{
  // ... other configuration ...
  Destroy: false,
}

Passing Provider Code

resource.TestStep{
  // ... other configuration ...
}