New Check: Extraneous Zero Value Checking With GetOk

[bflad]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Using the (*helper/schema.ResourceData).GetOk() receiver method will automatically check against the zero-value for the type, e.g.

• bool against false
• int against 0
• string against ""

Capture when the resource logic immediately performs the same conditional.

New or Affected Checks(s)

• R###

Flagged Provider Code

if v, ok := d.GetOk("attr"); ok && v.(bool) { // ...

if v, ok := d.GetOk("attr"); ok && v.(int) != 0 { // ...

if v, ok := d.GetOk("attr"); ok && v.(string) != "" { // ...

Passing Provider Code

if v, ok := d.GetOk("attr"); ok { // ...