Terraform Plugin SDK v2 Support

[bflad]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Terraform Plugin SDK v2 has just shipped!

Some housekeeping items:

• Given that tfproviderlint is very dependent on Go module import paths, e.g. github.com/hashicorp/terraform-plugin-sdk/helper/schema, various places will need to be added to support the new versioning where it makes sense, e.g. github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema
• Any SDK v2 irrelevant checks, such as v1 deprecations that now will result in compilation errors, should be noted in this issue and likely removed.
• Any SDK v2 deprecations, such as those in the upgrade guide, should have issues created.
• The README.md file should be updated to denote which versions of this tool support which versions of the SDK

Once those changes are in, a major version should be released.

Affected Checks(s)

• TBD

References

• https://discuss.hashicorp.com/t/announcing-v2-0-0-of-the-plugin-sdk/12218
• https://www.terraform.io/docs/extend/guides/v2-upgrade-guide.html

[bflad]

It looks like we can easily (and probably should!) support multiple versions of the SDK. #179 implemented the initial support for this and will be released in v0.15.0 of tfproviderlint.

New V2 Check issues:

• New Check: V2 schema.Schema.ValidateFunc Deprecation New Check: V2 schema.Schema.ValidateFunc Deprecation #169
• New Check: V2 (*resource.StateChangeConf).WaitForState() Deprecation New Check: V2 (*resource.StateChangeConf).WaitForState() Deprecation #181
• New Check: V2 resource.Retry() Deprecation New Check: V2 resource.Retry() Deprecation #182
• New Check: V2 schema.Provider.ConfigureFunc Deprecation New Check: V2 schema.Provider.ConfigureFunc Deprecation #183
• New Check: V2 schema.Resource.Create Deprecation New Check: V2 schema.Resource.Create Deprecation #184
• New Check: V2 schema.Resource.Delete Deprecation New Check: V2 schema.Resource.Delete Deprecation #185
• New Check: V2 schema.Resource.Read Deprecation New Check: V2 schema.Resource.Read Deprecation #186
• New Check: V2 schema.Resource.Update Deprecation New Check: V2 schema.Resource.Update Deprecation #187
• New Check: V2 schema.ResourceImporter.State Deprecation New Check: V2 schema.ResourceImporter.State Deprecation #188
• New Check: V2 schema.ImportStatePassthrough() Deprecation New Check: V2 schema.ImportStatePassthrough() Deprecation #189