This repository has been archived by the owner on Aug 22, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 717
Scrolling away from counter then back again gives incorrect final value #28
Comments
In Chrome I had numbers 0 ... 0 ... 0 Your fix helped. Thanks ! |
Fixed for me too! You should make a pull request or fork. This project doesn't seem to kept up with. |
onepartscissors
added a commit
to onepartscissors/Counter-Up
that referenced
this issue
Feb 25, 2016
Hi All, i needed this more reliable for a project, so i forked it and added a 'total' variable that it always relies on. If the total is missing, it will work as per the original, using the text supplied by "$this.text()". Here it is: |
You can look up a simple solution on the CounterUp side (rather than changing WayPoint integration) on my reply at #57 (comment). It is a needed fix anyway, even if you use the correct new WayPoint methods. |
Thanks, this fork works for me :D |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I came across a problem with scrolling away from the counter whilst it was still in progress and then scrolling back again
If the original value is 100 and I scrolled away at 50, when I scrolled back it would count from 0 to 50 not 100
I fixed this by:
var $settings = settings;
var $originalText = $this.text(); // added this line
Changed:
var num = $this.text();
to
var num = $originalText;
The text was updated successfully, but these errors were encountered: