Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept cookies button is actually a Save button #65

Open
silllli opened this issue Jun 5, 2024 · 0 comments · May be fixed by #68
Open

Accept cookies button is actually a Save button #65

silllli opened this issue Jun 5, 2024 · 0 comments · May be fixed by #68

Comments

@silllli
Copy link

silllli commented Jun 5, 2024

As far as I can see it, the Accept cookies button is actually a Save button. If a user adjusts their preferences, clicking on Accept cookies won’t accept (all) cookies, but save the selected choices.

Shouldn’t the button label read Save and another button be introduced, which will in fact Accept (all) cookies when clicked?

That way a user has the choice to accept all, reject all, or choose and save.

So the needed buttons and labels would be:

  • acceptLabel: Accept all
  • rejectLabel: Reject all
  • settingsLabel: Cookie settings
  • closeLabel: Close settings
  • editLabel: Edit cookie settings
  • saveLabel: Accept selected
@silllli silllli linked a pull request Jun 5, 2024 that will close this issue
@silllli silllli changed the title ‘Confirm all’ button is actually a ‘save’ button ‘Accept cookies’ button is actually a ‘save’ button Jun 5, 2024
@silllli silllli changed the title ‘Accept cookies’ button is actually a ‘save’ button Accept cookies button is actually a Save button Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant